On Thu, Jan 27, 2022 at 06:55:23PM -0600, Steve French wrote: > Regression tests so far on Dave's cifs fscache patch series are going > fine. First series of tests I ran were this: > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/11/builds/160 > but I have to run additional tests with fscache enabled etc. > > I saw that checkpatch had some minor complaints on this patch (patch > 4) which I cleaned up, but was wondering other's thoughts on this > checkpatch warning: > > WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code > rather than BUG() or BUG_ON() > #101: FILE: fs/cifs/file.c:4449: > > ie > > + page = readahead_page(ractl); > + BUG_ON(!page); Just remove it. The kernel will crash just fine without putting in an explicit BUG_ON, and it'll be obvious what the problem is. -- Linux-cachefs mailing list Linux-cachefs@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/linux-cachefs
