On Wed, Jan 12, 2022 at 6:17 AM David Howells <dhowells@xxxxxxxxxx> wrote: > > Can you try applying the attached patch? It has some debugging to check that > the cifs file it's trying to close actually got opened. It turns out that > some paths through were either managing to escape that or were going through > when they shouldn't have been. With this patch on 0111 tree, the panic is gone. The panic looks like: [ 85.319031] Attempt to set a LOCK_MAND lock via flock(2). This support has been removed and the request ignored. [ 85.320889] FS-Cache: [ 85.321265] FS-Cache: Assertion failed [ 85.321763] FS-Cache: ffffffffffffffff == 0 is false [ 85.322740] ------------[ cut here ]------------ [ 85.323508] kernel BUG at fs/fscache/cookie.c:957! [ 85.324439] invalid opcode: 0000 [#1] PREEMPT SMP PTI [ 85.325266] CPU: 0 PID: 7 Comm: kworker/0:1 Not tainted 5.16.0-next-20220107-next-20220107 #1 [ 85.326672] Hardware name: Red Hat KVM/RHEL-AV, BIOS 1.15.0-1.el9 04/01/2014 [ 85.327830] Workqueue: deferredclose smb2_deferred_work_close [cifs] [ 85.328975] RIP: 0010:__fscache_relinquish_cookie.cold+0x2a/0x5c [fscache] [ 85.330214] Code: 48 c7 c7 bd 63 c7 c0 e8 ff ed 20 d5 48 c7 c7 cb 63 c7 c0 e8 f3 ed 20 d5 48 63 75 04 31 d2 48 c7 c7 d8 70 c7 c0 e8 e1 ed 20 d5 <0f> 0b 48 c7 c7 bd 63 c7 c0 e8 d3 ed 20 d5 48 c7 c7 cb 63 c7 c0 e8 [ 85.333222] RSP: 0018:ffffac8b00043d40 EFLAGS: 00010246 [ 85.334070] RAX: 0000000000000028 RBX: ffff900ac2954d88 RCX: 0000000000000000 [ 85.335230] RDX: 0000000000000000 RSI: ffff900b3dc1fcc0 RDI: ffff900b3dc1fcc0 [ 85.336388] RBP: ffff900addd19370 R08: 0000000000000000 R09: ffffac8b00043b88 [ 85.337587] R10: ffffac8b00043b80 R11: ffffffff971e5a68 R12: ffff900ac2954cf8 [ 85.338808] R13: ffff900ac367b000 R14: 000000000000001a R15: ffff900b0d5e7a00 [ 85.339333] FS-Cache: [ 85.339969] FS: 0000000000000000(0000) GS:ffff900b3dc00000(0000) knlGS:0000000000000000 [ 85.340333] FS-Cache: Assertion failed [ 85.341652] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 85.341654] CR2: 00007f364bb6cf18 CR3: 0000000002202006 CR4: 0000000000170ef0 [ 85.341657] Call Trace: [ 85.341660] <TASK> [ 85.342161] FS-Cache: ffffffffffffffff == 0 is false [ 85.343111] cifs_fscache_release_inode_cookie+0x22/0x80 [cifs] [ 85.344035] ------------[ cut here ]------------ [ 85.344443] cifsFileInfo_put_final+0x39/0x150 [cifs] [ 85.344731] kernel BUG at fs/fscache/cookie.c:957! [ 85.345570] _cifsFileInfo_put+0x23d/0x3e0 [cifs] [ 85.349557] ? smb2_deferred_work_close+0x30/0x60 [cifs] [ 85.350466] process_one_work+0x1e5/0x3b0 [ 85.351745] worker_thread+0x50/0x3a0 [ 85.352929] ? rescuer_thread+0x370/0x370 [ 85.354218] kthread+0xca/0xf0 [ 85.355309] ? kthread_complete_and_exit+0x20/0x20 [ 85.356644] ret_from_fork+0x22/0x30 [ 85.357853] </TASK> -- Linux-cachefs mailing list Linux-cachefs@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/linux-cachefs
