On 12/27/21 11:36 PM, Matthew Wilcox wrote: > On Mon, Dec 27, 2021 at 08:54:40PM +0800, Jeffle Xu wrote: >> + spin_lock(&cache->reqs_lock); >> + ret = idr_alloc(&cache->reqs, req, 0, 0, GFP_KERNEL); > > GFP_KERNEL while holding a spinlock? Right. Thanks for pointing it out. > > You should be using an XArray instead of an IDR in new code anyway. > Regards. -- Thanks, Jeffle -- Linux-cachefs mailing list Linux-cachefs@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/linux-cachefs
