On Mon, 2021-11-29 at 16:46 +0000, David Howells wrote:
> Jeff Layton <jlayton@xxxxxxxxxx> wrote:
>
> > +void ceph_fscache_unregister_inode_cookie(struct ceph_inode_info* ci)
> > {
> > - return fscache_register_netfs(&ceph_cache_netfs);
> > + struct fscache_cookie* cookie = xchg(&ci->fscache, NULL);
> > +
> > + fscache_relinquish_cookie(cookie, false);
> > }
>
> xchg() should be excessive there. This is only called from
> ceph_evict_inode(). Also, if you're going to reset the pointer, it might be
> worth poisoning it rather than nulling it.
>
Ok, makes sense. I'll make that change soon.
--
Jeff Layton <jlayton@xxxxxxxxxx>
--
Linux-cachefs mailing list
Linux-cachefs@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/linux-cachefs
