Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> > -static int afs_symlink_readpage(struct page *page)
> > +static int afs_symlink_readpage(struct file *file, struct page *page)
> > {
> > struct afs_vnode *vnode = AFS_FS_I(page->mapping->host);
> > struct afs_read *fsreq;
>
>
> I wonder...would you be better served here by not using page_readlink
> for symlinks and instead use simple_get_link and roll your own readlink
> operation. It seems a bit more direct, and AFS seems to be the only
> caller of page_readlink.
Maybe. At some point it will need to go through netfs_readpage() so that it
will get cached and maybe encrypted. Possibly there should be a
netfs_readlink(). AFS directories too will at some point need to go through
netfs_readahead() or similar.
David
--
Linux-cachefs mailing list
Linux-cachefs@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/linux-cachefs
