Except for the implementation details using the unions field (I'm not going to mention these going forward), this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- Linux-cachefs mailing list Linux-cachefs@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/linux-cachefs