When there's a collision due to a duplicate cookie, __fscache_register_netfs will do an fscache_cookie_put. This, however, isn't required as fscache_cookie_get hasn't been executed, and will lead to a NULL pointer as fscache_unhash_cookie will be called. Signed-off-by: Luis Henriques <lhenriques@xxxxxxxx> --- fs/fscache/netfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/fscache/netfs.c b/fs/fscache/netfs.c index cce92216fa28..07a55371f0a4 100644 --- a/fs/fscache/netfs.c +++ b/fs/fscache/netfs.c @@ -52,7 +52,6 @@ int __fscache_register_netfs(struct fscache_netfs *netfs) return 0; already_registered: - fscache_cookie_put(candidate, fscache_cookie_put_dup_netfs); _leave(" = -EEXIST"); return -EEXIST; } -- Linux-cachefs mailing list Linux-cachefs@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/linux-cachefs