Re: [PATCH 1/1][FSCACHE] Fix to handle Oops in fscache module during cookie cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



KiranKumar Modukuri <kiran.modukuri@xxxxxxxxx> wrote:

> -       object->cookie = cookie;
> +       if (cookie) {
> +               if (atomic_inc_not_zero(&cookie->usage)) {
> +                       object->cookie = cookie;
> +               }
> +       }

Note that this doesn't need to be conditional if you export
fscache_fsdef_index and pass that in to fscache_object_init() as the cookie in
cachefiles_daemon_add_cache().  I'm slightly leery of making it look like
cookie is optional.

David

--
Linux-cachefs mailing list
Linux-cachefs@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/linux-cachefs



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]
  Powered by Linux