John Snow <jsnow@xxxxxxxxxx> wrote:
> > + if (!*sp || !isspace(*sp) || b_thresh == 0)
> > + cfgerror("Invalid resume threshold (blocks)");
>
> Seems to me like we're mixing parsing errors with invalid configuration
> error messages, but I'm just bike-shedding aboard the SS Howells.
How about this further modification?
- if (!*sp || !isspace(*sp) || b_thresh == 0)
+ if (!*sp || !isspace(*sp))
+ cfgerror("Error parsing resume threshold (blocks)");
+ if (b_thresh == 0)
cfgerror("Invalid resume threshold (blocks)");
for (; isspace(*sp); sp++) {;}
@@ -470,7 +472,9 @@ int main(int argc, char *argv[])
f_thresh = ULLONG_MAX;
} else {
f_thresh = strtoul(sp, &sp, 10);
- if (*sp || f_thresh == 0)
+ if (*sp)
+ cfgerror("Error parsing resume threshold (files)");
+ if (f_thresh == 0)
cfgerror("Invalid resume threshold (files)");
David
--
Linux-cachefs mailing list
Linux-cachefs@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/linux-cachefs
