Jeff Layton <jlayton@xxxxxxxxxx> wrote: > > @@ -333,7 +333,8 @@ int __wait_on_atomic_t(wait_queue_head_t *wq, struct wait_bit_queue *q, > > prepare_to_wait(wq, &q->wait, mode); > > val = q->key.flags; > > if (atomic_read(val) == 0) > > - ret = (*action)(val); > > + break; > > + ret = (*action)(val); > > } while (!ret && atomic_read(val) != 0); > > nit: can you now eliminate the check for "val" in the while condition? > It doesn't look like it harms anything, but eliminating it would > probably simplify the code slightly... Its presence means that we don't have to call prepare_to_wait() again if val became 0. David -- Linux-cachefs mailing list Linux-cachefs@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/linux-cachefs
