Trond Myklebust <trond.myklebust@xxxxxxxxxx> wrote: > > > Dang, that's a lot of inlines... AFAICS, approx half of fs/nfs/fscache.h > > > should really be moved into fscache.c. > > > > If you wish. It seems a shame since a lot of them have only one caller. > > ...however it also forces you to export a lot of stuff which is really > private to fscache.c (the atomics etc). The atomics is actually a bad example. These are referred to directly by part of the table in fs/nfs/sysctl.c. Is there a better way of exporting statistics than through /proc/sys/ files? David