James Morris <jmorris@xxxxxxxxx> wrote: > > + u32 (*inode_get_secid)(struct inode *inode); > > To maintain API consistency, please return an int which only acts as an > error code, and returning the secid via a *u32 function parameter. Does that apply to *all* the functions, irrespective of whether or not they return an error? David
