David Howells <dhowells@xxxxxxxxxx> wrote: > > Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > > The attached patch exports find_get_pages() for use by the kAFS filesystem > > > in conjunction with it caching patch. > > > > Why don't you use pagevec ? > > You mean pagevec_lookup() I suppose... That's probably reasonable, though > slower. > But the code's using pagevecs now. In a strange manner. + nr_pages = find_get_pages(vnode->vfs_inode.i_mapping, first, + PAGEVEC_SIZE, pvec.pages); that's an open-coded pagevec_lookup().