Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote: > Having the smp_rmb() here implies there is some sort of memory barrier > based synchronisation protocol at a higher level (than this function), > because you don't actually do anything before them smp_rmb() here. > > So can you comment what that is? Hmmm... That probably shouldn't be there. I don't think Andrew Morton and I actually came to an agreement as to whether it's necessary. I don't think it is, he thought that it was, though he may have changed his mind. David