Re: [PATCH] doc: update RWBS descriptions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Stefan Hajnoczi <stefanha@xxxxxxxxxx> writes:

> Barriers no longer exist but a number of other flags have been added.
> Document them.

It's possible to run the tool against older kernels, so perhaps we
should keep a note about barriers at the end of the man page.

Aside from that, this looks fine to me.

-Jeff

>
> Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
> ---
>  doc/blkparse.1   | 34 +++++++++++++++++++++++++++++++---
>  doc/blktrace.tex | 20 +++++++++++++++++---
>  2 files changed, 48 insertions(+), 6 deletions(-)
>
> diff --git a/doc/blkparse.1 b/doc/blkparse.1
> index 4c26baf..722efff 100644
> --- a/doc/blkparse.1
> +++ b/doc/blkparse.1
> @@ -435,10 +435,38 @@ Split
>  
>  .SH "RWBS DESCRIPTION"
>  
> -This is a small string containing at least one character ('R' for read, 'W'
> -for write, or 'D' for block discard operation), and optionally either
> -a 'B' (for barrier operations) or 'S' (for synchronous operations).
> +This is a small string containing characters in the following order:
>  
> +.IP F
> +Flush
> +
> +.IP R
> +Read
> +
> +.IP W
> +Write
> +
> +.IP D
> +Discard
> +
> +.IP N
> +Other operation
> +
> +.IP F
> +Force Unit Access (FUA)
> +
> +.IP A
> +Readahead
> +
> +.IP S
> +Synchronous
> +
> +.IP M
> +Meta
> +
> +.PP
> +One of 'R', 'W', 'D', or 'N' is always present. The other characters are
> +optional. Note that 'F' has two meanings, depending on its position.
>  
>  .SH "DEFAULT OUTPUT"
>  
> diff --git a/doc/blktrace.tex b/doc/blktrace.tex
> index 836ac4a..6a33fb6 100644
> --- a/doc/blktrace.tex
> +++ b/doc/blktrace.tex
> @@ -653,9 +653,23 @@ X & Split \\ \hline
>  \end{tabular}
>  
>  \subsubsection{\label{sec:act-table}RWBS Description}
> -This is a small string containing at least one character ('R' for read,
> -'W' for write, or 'D' for block discard operation), and optionally either
> -a 'B' (for barrier operations) or 'S' (for synchronous operations).
> +This is a small string containing characters in the following order:
> +
> +\begin{tabular}{|l|l|}\hline
> +Character & Description \\ \hline\hline
> +F & Flush \\ \hline
> +R & Read \\ \hline
> +W & Write \\ \hline
> +D & Discard \\ \hline
> +N & Other operation \\ \hline
> +F & Force Unit Access (FUA) \\ \hline
> +A & Readahead \\ \hline
> +S & Synchronous \\ \hline
> +M & Meta \\ \hline
> +\end{tabular}
> +
> +One of 'R', 'W', 'D', or 'N' is always present. The other characters are
> +optional. Note that 'F' has two meanings, depending on its position.
>  
>  \subsubsection{\label{sec:default-output}Default output}





[Index of Archives]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux