On 06/17/2019 08:53 AM, Bart Van Assche wrote: > On 6/16/19 6:28 PM, Chaitanya Kulkarni wrote: >> Changes from V1:- >> >> 1. Drop the target_pscsi patch. (Bart) >> 2. Remove rcu locking which is not needed. (Bart) >> >> Chaitanya Kulkarni (7): >> block: add a helper function to read nr_setcs >> blk-zoned: update blkdev_nr_zones() with helper >> blk-zoned: update blkdev_report_zone() with helper >> blk-zoned: update blkdev_reset_zones() with helper >> bcache: update cached_dev_init() with helper >> f2fs: use helper in init_blkz_info() >> blktrace: use helper in blk_trace_setup_lba() >> >> block/blk-zoned.c | 12 ++++++------ >> drivers/md/bcache/super.c | 2 +- >> fs/f2fs/super.c | 2 +- >> include/linux/blkdev.h | 10 ++++++++++ >> kernel/trace/blktrace.c | 2 +- >> 5 files changed, 19 insertions(+), 9 deletions(-) > > My feedback about the pscsi_get_blocks() was misleading: what I meant is > that it is not necessary to introduce RCU locking in that function. I > think that using bdev_nr_sects() or part_nr_sects_read() to read > nr_sects in that function is useful. > My bad. I'll add pscsi patch. > Is there any reason that the following Xen macro has not been converted? > > #define vbd_sz(_v) ((_v)->bdev->bd_part ? \ > (_v)->bdev->bd_part->nr_sects : \ > get_capacity((_v)->bdev->bd_disk)) > I'll convert this too and appropriate mailing list. Thanks Bart again for detailed feedback. > Thanks, > > Bart. >
