> Removed redundant from-sector parameter: it's /always/ the bio's sector > passed in. > > Signed-off-by: Alan D. Brunelle <alan.brunelle@xxxxxx> > Cc: Jens Axboe <jens.axboe@xxxxxxxxxx> > Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> > Reviewed-by: Li Zefan <lizf@xxxxxxxxxxxxxx> I reviewed the older version of this patch, but didn't review it again when Alan sent out this revised one, and I just found a typo in it... > Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> ... > DECLARE_TRACE(block_remap, > TP_PROTO(struct request_queue *q, struct bio *bio, dev_t dev, > - sector_t to, sector_t from), > - TP_ARGS(q, bio, dev, to, from)); > + sector_t to), > + TP_ARGS(q, bio, dev, to)); It should be 'from', not 'to'. ============== From: Li Zefan <lizf@xxxxxxxxxxxxxx> Subject: [PATCH] blktrace: from-sector redundant in trace_block_remap, fix The last argument of block_remap prober is the original sector before remap, so it should be 'from', not 'to'. [ Impact: clean up ] Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx> --- include/trace/block.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/trace/block.h b/include/trace/block.h index 8ac945b..5b12efa 100644 --- a/include/trace/block.h +++ b/include/trace/block.h @@ -70,7 +70,7 @@ DECLARE_TRACE(block_split, DECLARE_TRACE(block_remap, TP_PROTO(struct request_queue *q, struct bio *bio, dev_t dev, - sector_t to), - TP_ARGS(q, bio, dev, to)); + sector_t from), + TP_ARGS(q, bio, dev, from)); #endif -- 1.5.4.rc3 -- To unsubscribe from this list: send the line "unsubscribe linux-btrace" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
