This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=668569 ---Test result--- Test Summary: CheckPatch FAIL 22.27 seconds GitLint PASS 9.44 seconds Prep - Setup ELL PASS 32.78 seconds Build - Prep PASS 0.90 seconds Build - Configure PASS 11.01 seconds Build - Make PASS 976.97 seconds Make Check PASS 13.21 seconds Make Check w/Valgrind PASS 348.16 seconds Make Distcheck PASS 303.38 seconds Build w/ext ELL - Configure PASS 11.01 seconds Build w/ext ELL - Make PASS 100.58 seconds Incremental Build w/ patches PASS 1072.20 seconds Scan Build WARNING 1121.57 seconds Details ############################## Test: CheckPatch - FAIL Desc: Run checkpatch.pl script with rule in .checkpatch.conf Output: [BlueZ,3/9] shared/bap: Add initial code for handling BAP ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. #331: FILE: src/shared/bap.c:19: + * License along with this library; if not, write to the Free Software$ ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. #332: FILE: src/shared/bap.c:20: + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA$ WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment #1707: FILE: src/shared/bap.c:1395: + /* Fallthrough */ WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment #1713: FILE: src/shared/bap.c:1401: + /* Fallthrough */ WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment #1726: FILE: src/shared/bap.c:1414: + /* Fallthrough */ WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment #1732: FILE: src/shared/bap.c:1420: + /* Fallthrough */ WARNING:BRACES: braces {} are not necessary for single statement blocks #2523: FILE: src/shared/bap.c:2211: + for (i = 0; i < hdr->num; i++) { + ret = handler->func(ascs, bap, &iov, rsp); + } ERROR:SPACING: space required before the open parenthesis '(' #4434: FILE: src/shared/bap.c:4122: + switch(lpac->type) { WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) #5114: FILE: src/shared/bap.h:16: +#define __packed __attribute__((packed)) WARNING:SPACING: Unnecessary space before function pointer arguments #5221: FILE: src/shared/bap.h:123: + int (*select) (struct bt_bap_pac *pac, struct bt_bap_pac_qos *qos, WARNING:SPACING: Unnecessary space before function pointer arguments #5224: FILE: src/shared/bap.h:126: + int (*config) (struct bt_bap_stream *stream, struct iovec *cfg, WARNING:SPACING: Unnecessary space before function pointer arguments #5227: FILE: src/shared/bap.h:129: + void (*clear) (struct bt_bap_stream *stream, void *user_data); /github/workspace/src/12946591.patch total: 3 errors, 9 warnings, 5252 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/12946591.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. [BlueZ,4/9] profiles: Add initial code for bap plugin ERROR:SPACING: space prohibited before that close parenthesis ')' #599: FILE: profiles/audio/bap.c:471: + { "properties", "a{sv}" } ), ERROR:INITIALISED_STATIC: do not initialise statics to 0 #1406: FILE: profiles/audio/bap.c:1278: +static unsigned int bap_id = 0; WARNING:SPACING: Unnecessary space before function pointer arguments #2332: FILE: profiles/audio/transport.c:116: + void (*set_state) (struct media_transport *transport, /github/workspace/src/12946588.patch total: 2 errors, 1 warnings, 2814 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/12946588.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. [BlueZ,8/9] client/player: Add support for PACS endpoints ERROR:SPACING: space prohibited before that close parenthesis ')' #631: FILE: client/player.c:1886: + GDBUS_ARGS({ "cfg", "ay" } ), ERROR:SPACING: space prohibited before that close parenthesis ')' #634: FILE: client/player.c:1889: + GDBUS_ARGS({ "properties", "a{sv}" } ), ERROR:SPACING: space prohibited before that close parenthesis ')' #635: FILE: client/player.c:1890: + GDBUS_ARGS({ "properties", "a{sv}" } ), /github/workspace/src/12946590.patch total: 3 errors, 0 warnings, 799 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/12946590.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ############################## Test: Scan Build - WARNING Desc: Run Scan Build with patches Output: ***************************************************************************** The bugs reported by the scan-build may or may not be caused by your patches. Please check the list and fix the bugs if they are caused by your patch. ***************************************************************************** client/player.c:1757:25: warning: Dereference of null pointer iov_append(&cfg->caps, preset->data.iov_base, preset->data.iov_len); ^~~~~~~~~~~~~~~~~~~~~ 1 warning generated. profiles/audio/media.c:1450:6: warning: 8th function call argument is an uninitialized value if (media_endpoint_create(adapter, sender, path, uuid, delay_reporting, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/media.c:2996:3: warning: Use of memory after it is freed release_endpoint(adapter->endpoints->data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/media.c:2999:3: warning: Use of memory after it is freed media_player_destroy(adapter->players->data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 3 warnings generated. src/shared/bap.c:1217:9: warning: Use of memory after it is freed link = queue_find(stream->links, match_stream_io, io); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. --- Regards, Linux Bluetooth
