On Tue, Aug 09, 2022 at 08:35:24AM -0700, Manish Mandlik wrote: > The /sys/class/devcoredump/disabled provides only one-way disable > functionality. Also, disabling devcoredump using it disables the > devcoredump functionality for everyone who is using it. > > Provide a way to selectively enable/disable devcoredump for the device > which is bound to a driver that implements the '.coredump()' callback. > > This adds the 'coredump_disabled' driver attribute. When the driver > implements the '.coredump()' callback, 'coredump_disabled' file is added > along with the 'coredump' file in the sysfs folder of the device upon > driver binding. The file is removed when the driver is unbound. > > Drivers can use this attribute to enable/disable devcoredump and the > userspace can write 0 or 1 to /sys/devices/.../coredump_disabled sysfs > entry to control enabling/disabling of devcoredump for that device. > > Signed-off-by: Manish Mandlik <mmandlik@xxxxxxxxxx> > Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@xxxxxxxxxxxx> > --- > > Changes in v4: > - New patch in the series > > drivers/base/dd.c | 43 +++++++++++++++++++++++++++++++++++--- > drivers/base/devcoredump.c | 2 +- > include/linux/device.h | 4 ++++ > 3 files changed, 45 insertions(+), 4 deletions(-) You can't add a new sysfs file without also a Documentation/ABI update at the same time :( thanks, greg k-h
