This memory leak will never happen, however since we added a new return from function that malloc'd memory, the free should still be done. --- mesh/mesh-config-json.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mesh/mesh-config-json.c b/mesh/mesh-config-json.c index 5bb1e5ce0..7f46c8582 100644 --- a/mesh/mesh-config-json.c +++ b/mesh/mesh-config-json.c @@ -1961,8 +1961,10 @@ bool mesh_config_comp_page_add(struct mesh_config *cfg, uint8_t page, len = (size * 2) + 3; buf = l_malloc(len); ret = snprintf(buf, len, "%2.2x", page); - if (ret < 0) + if (ret < 0) { + l_free(buf); return false; + } hex2str(data, size, buf + 2, len - 2); -- 2.36.1