On Mon, Jun 6, 2022 at 11:00 PM Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> wrote: > > Right, thanks for fixing it. About some of the changes perhaps we > should use BIT when declaring values in enum hci_conn_flags? That sounds sane, although with just two flag values I'm not sure it matters. But I guess it would document the fact that it's a bitmask, not an ordinal value, and it looks like that header is already using BIT() elsewhere so there are no new header file dependencies.. Linus