Re: doc/coding-style: Update URL to kernel coding style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tedd,

On Sun, Jun 5, 2022 at 5:31 AM <bluez.test.bot@xxxxxxxxx> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=647329
>
> ---Test result---
>
> Test Summary:
> CheckPatch                    FAIL      1.41 seconds
> GitLint                       PASS      0.96 seconds
> Prep - Setup ELL              PASS      40.26 seconds
> Build - Prep                  PASS      0.68 seconds
> Build - Configure             PASS      7.98 seconds
> Build - Make                  PASS      1210.43 seconds
> Make Check                    PASS      11.64 seconds
> Make Check w/Valgrind         PASS      405.55 seconds
> Make Distcheck                PASS      222.88 seconds
> Build w/ext ELL - Configure   PASS      8.39 seconds
> Build w/ext ELL - Make        PASS      1183.08 seconds
> Incremental Build with patchesPASS      0.00 seconds
>
> Details
> ##############################
> Test: CheckPatch - FAIL
> Desc: Run checkpatch.pl script with rule in .checkpatch.conf
> Output:
> doc/coding-style: Update URL to kernel coding style
> WARNING:BAD_SIGN_OFF: '-signed-off-by:' is the preferred signature form
> #95: FILE: doc/coding-style.txt:9:
> -Signed-off-by: line(s)". BlueZ does not used Signed-Off lines, so including
>
> ERROR:BAD_SIGN_OFF: Unrecognized email address: 'line(s)". BlueZ does not used Signed-Off lines, so including'
> #95: FILE: doc/coding-style.txt:9:
> -Signed-off-by: line(s)". BlueZ does not used Signed-Off lines, so including

This one is quite funny, it seems checkpatch.pl does actually end up
checking for Signed-off-by: lines even on the patch contents rather
than limiting it to just the git commit not sure if there is something
we can do about it but this is the exact thing the patches wants to
prevent.

> /github/workspace/src/12869423.patch total: 1 errors, 1 warnings, 22 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
>
> /github/workspace/src/12869423.patch has style problems, please review.
>
> NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
>
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
>
>
>
> ---
> Regards,
> Linux Bluetooth
>


-- 
Luiz Augusto von Dentz



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux