Hi Jiasheng, > As platform_driver_register() could fail, it should be better > to deal with the return value in order to maintain the code > consisitency. > > Fixes: 1ab1f239bf17 ("Bluetooth: hci_intel: Add support for platform driver") > Signed-off-by: Jiasheng Jiang <jiasheng@xxxxxxxxxxx> > --- > drivers/bluetooth/hci_intel.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/hci_intel.c b/drivers/bluetooth/hci_intel.c > index 7249b91d9b91..d4801b26cc8e 100644 > --- a/drivers/bluetooth/hci_intel.c > +++ b/drivers/bluetooth/hci_intel.c > @@ -1217,7 +1217,11 @@ static struct platform_driver intel_driver = { > > int __init intel_init(void) > { > - platform_driver_register(&intel_driver); > + int ret; > + > + ret = platform_driver_register(&intel_driver); > + if (ret) > + return ret; most of the driver uses int err. So please do that as well. Regards Marcel