Re: [PATCH 3/8] Bluetooth: Add initial implementation of CIS connections

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

I love your patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on v5.18-rc5 next-20220505]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Luiz-Augusto-von-Dentz/Bluetooth-eir-Add-helpers-for-managing-service-data/20220506-070828
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: sparc-randconfig-s032-20220505 (https://download.01.org/0day-ci/archive/20220506/202205060934.yZqT8q6k-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 11.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/intel-lab-lkp/linux/commit/aec184428c78dfd0b7d66190234e7fb4b92c9330
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Luiz-Augusto-von-Dentz/Bluetooth-eir-Add-helpers-for-managing-service-data/20220506-070828
        git checkout aec184428c78dfd0b7d66190234e7fb4b92c9330
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sparc SHELL=/bin/bash net/bluetooth/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)
>> net/bluetooth/hci_conn.c:1250:21: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] c_sdu @@     got unsigned short [usertype] sdu @@
   net/bluetooth/hci_conn.c:1250:21: sparse:     expected restricted __le16 [usertype] c_sdu
   net/bluetooth/hci_conn.c:1250:21: sparse:     got unsigned short [usertype] sdu
>> net/bluetooth/hci_conn.c:1251:21: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] p_sdu @@     got unsigned short [usertype] sdu @@
   net/bluetooth/hci_conn.c:1251:21: sparse:     expected restricted __le16 [usertype] p_sdu
   net/bluetooth/hci_conn.c:1251:21: sparse:     got unsigned short [usertype] sdu
--
   net/bluetooth/hci_event.c:337:15: sparse: sparse: restricted __le16 degrades to integer
>> net/bluetooth/hci_event.c:3788:26: sparse: sparse: cast to restricted __le16
>> net/bluetooth/hci_event.c:3788:26: sparse: sparse: cast to restricted __le16
>> net/bluetooth/hci_event.c:3788:26: sparse: sparse: cast to restricted __le16
>> net/bluetooth/hci_event.c:3788:26: sparse: sparse: cast to restricted __le16
   net/bluetooth/hci_event.c:3790:26: sparse: sparse: cast to restricted __le16
   net/bluetooth/hci_event.c:3790:26: sparse: sparse: cast to restricted __le16
   net/bluetooth/hci_event.c:3790:26: sparse: sparse: cast to restricted __le16
   net/bluetooth/hci_event.c:3790:26: sparse: sparse: cast to restricted __le16
   net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
   include/net/bluetooth/hci.h:2518:47: sparse: sparse: array of flexible structures
   include/net/bluetooth/hci.h:2604:43: sparse: sparse: array of flexible structures
>> net/bluetooth/hci_event.c:6685:38: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] sdu @@     got restricted __le16 [usertype] c_mtu @@
   net/bluetooth/hci_event.c:6685:38: sparse:     expected unsigned short [usertype] sdu
   net/bluetooth/hci_event.c:6685:38: sparse:     got restricted __le16 [usertype] c_mtu
>> net/bluetooth/hci_event.c:6686:39: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] sdu @@     got restricted __le16 [usertype] p_mtu @@
   net/bluetooth/hci_event.c:6686:39: sparse:     expected unsigned short [usertype] sdu
   net/bluetooth/hci_event.c:6686:39: sparse:     got restricted __le16 [usertype] p_mtu

vim +1250 net/bluetooth/hci_conn.c

  1244	
  1245	static void cis_add(struct iso_list_data *d, struct bt_iso_qos *qos)
  1246	{
  1247		struct hci_cis_params *cis = &d->pdu.cis[d->pdu.cp.num_cis];
  1248	
  1249		cis->cis_id = qos->cis;
> 1250		cis->c_sdu  = qos->out.sdu;
> 1251		cis->p_sdu  = qos->in.sdu;
  1252		cis->c_phy  = qos->out.phy;
  1253		cis->p_phy  = qos->in.phy;
  1254		cis->c_rtn  = qos->out.rtn;
  1255		cis->p_rtn  = qos->in.rtn;
  1256	
  1257		d->pdu.cp.num_cis++;
  1258	}
  1259	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux