Hi Luiz, I love your patch! Perhaps something to improve: [auto build test WARNING on bluetooth-next/master] [also build test WARNING on bluetooth/master v5.18-rc5 next-20220505] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Luiz-Augusto-von-Dentz/Bluetooth-eir-Add-helpers-for-managing-service-data/20220506-070828 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master config: riscv-randconfig-r042-20220505 (https://download.01.org/0day-ci/archive/20220506/202205060852.Supq0SZS-lkp@xxxxxxxxx/config) compiler: riscv64-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d69aaead9db3307f674a711d3db70e884b31d381 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Luiz-Augusto-von-Dentz/Bluetooth-eir-Add-helpers-for-managing-service-data/20220506-070828 git checkout d69aaead9db3307f674a711d3db70e884b31d381 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash net/bluetooth/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> net/bluetooth/hci_conn.c:1361:18: warning: no previous prototype for 'hci_add_bis' [-Wmissing-prototypes] 1361 | struct hci_conn *hci_add_bis(struct hci_dev *hdev, bdaddr_t *dst, | ^~~~~~~~~~~ >> net/bluetooth/hci_conn.c:1874:18: warning: no previous prototype for 'hci_bind_bis' [-Wmissing-prototypes] 1874 | struct hci_conn *hci_bind_bis(struct hci_conn *conn, struct bt_iso_qos *qos) | ^~~~~~~~~~~~ -- >> net/bluetooth/hci_sync.c:1056:5: warning: no previous prototype for 'hci_adv_bcast_annoucement' [-Wmissing-prototypes] 1056 | int hci_adv_bcast_annoucement(struct hci_dev *hdev, struct adv_info *adv) | ^~~~~~~~~~~~~~~~~~~~~~~~~ vim +/hci_add_bis +1361 net/bluetooth/hci_conn.c 1359 1360 /* This function requires the caller holds hdev->lock */ > 1361 struct hci_conn *hci_add_bis(struct hci_dev *hdev, bdaddr_t *dst, 1362 struct bt_iso_qos *qos) 1363 { 1364 struct hci_conn *conn; 1365 struct iso_list_data data; 1366 int err; 1367 1368 /* Let's make sure that le is enabled.*/ 1369 if (!hci_dev_test_flag(hdev, HCI_LE_ENABLED)) { 1370 if (lmp_le_capable(hdev)) 1371 return ERR_PTR(-ECONNREFUSED); 1372 return ERR_PTR(-EOPNOTSUPP); 1373 } 1374 1375 err = qos_set_big(hdev, qos); 1376 if (err) 1377 return ERR_PTR(err); 1378 1379 err = qos_set_bis(hdev, qos); 1380 if (err) 1381 return ERR_PTR(err); 1382 1383 data.big = qos->big; 1384 data.bis = qos->bis; 1385 data.count = 0; 1386 1387 /* Check if there is already a matching BIG/BIS */ 1388 hci_conn_hash_list_state(hdev, bis_list, ISO_LINK, BT_BOUND, &data); 1389 if (data.count) 1390 return ERR_PTR(-EADDRINUSE); 1391 1392 conn = hci_conn_hash_lookup_bis(hdev, dst, qos->big, qos->bis); 1393 if (conn) 1394 return ERR_PTR(-EADDRINUSE); 1395 1396 conn = hci_conn_add(hdev, ISO_LINK, dst, HCI_ROLE_MASTER); 1397 if (!conn) 1398 return ERR_PTR(-ENOMEM); 1399 1400 set_bit(HCI_CONN_PER_ADV, &conn->flags); 1401 conn->state = BT_CONNECT; 1402 1403 hci_conn_hold(conn); 1404 return conn; 1405 } 1406 -- 0-DAY CI Kernel Test Service https://01.org/lkp
