Re: [Bluez PATCH v3 0/3] Adding bonded flag to D-Bus property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Zhengping,

On Wed, May 4, 2022 at 2:54 PM Zhengping Jiang <jiangzp@xxxxxxxxxx> wrote:
>
> Hi Luiz,
>
> Sorry for the error. It should have been fixed in patch 2. I think I updated the wrong version.

Don't worry, I'm fixing it myself.

> Thanks,
> Zhengping
>
> On Wed, May 4, 2022 at 2:49 PM Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> wrote:
>>
>> Hi Zhengping,
>>
>> On Wed, May 4, 2022 at 2:09 PM Zhengping Jiang <jiangzp@xxxxxxxxxx> wrote:
>> >
>> > Currently BlueZ client can't know easily whether a device is bonded or
>> > not. This is causing issues for a number of applications. For example,
>> > in the Nearby Share case, the peer device is paired, but not bonded.
>> > This series will add the "Bonded" property in org.bluez.Device1 D-Bus
>> > interface. Changes are also made in bluetoothctl to show the status of
>> > the bonded flag as well as a list of bonded devices.
>> >
>> > Changes in v3:
>> > - Move documentation update to a separate patch
>> > - Add description to bonded and paired
>> > - Add an optional argument to the devices command to filter device list
>> > - Remove paired-devices command
>> >
>> > Changes in v2:
>> > - Move one variable declaration to the top following C90 standard
>> >
>> > Changes in v1:
>> > - Add "Bonded" to D-Bus interface
>> > - Send property changed signal if the bonded flag is changed
>> > - Show the status of the "Bonded" flag in bluetoothctl
>> > - Add option to show list of bonded devices
>> >
>> > Zhengping Jiang (3):
>> >   device: Add "Bonded" flag to dbus property
>> >   doc: add "Bonded" flag to dbus property
>> >   client: Add filter to devices and show Bonded in info
>> >
>> >  client/main.c      | 72 ++++++++++++++++++++++++++++++----------------
>> >  doc/device-api.txt | 12 +++++++-
>> >  src/device.c       | 38 ++++++++++++++++++++----
>> >  3 files changed, 91 insertions(+), 31 deletions(-)
>> >
>> > --
>> > 2.36.0.464.gb9c8b46e94-goog
>>
>> src/device.c: In function ‘device_set_bonded’:
>> src/device.c:6141:9: error: ISO C90 forbids mixed declarations and
>> code [-Werror=declaration-after-statement]
>>  6141 |         struct bearer_state *state = get_state(device, bdaddr_type);
>>       |
>>
>>
>> --
>> Luiz Augusto von Dentz



-- 
Luiz Augusto von Dentz




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux