Re: [PATCH v3 3/3] Bluetooth: btusb: Set HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN for QCA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

On Fri, Apr 1, 2022 at 10:30 AM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>
> Hi Luiz,
>
> > This sets HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN for QCA controllers
> > since SCO appear to not work when using HCI_OP_ENHANCED_SETUP_SYNC_CONN.
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=215576
> > Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
> > ---
> > drivers/bluetooth/btusb.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 50df417207af..2470c3d4ef0f 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -3335,6 +3335,9 @@ static int btusb_setup_qca(struct hci_dev *hdev)
> >                       msleep(QCA_BT_RESET_WAIT_MS);
> >       }
> >
> > +     /* https://bugzilla.kernel.org/show_bug.cgi?id=215576 */
>
> I dislike having a link here. Just describe what is going on.

Fair enough I will include the description of the problem instead of
just having the link.

> > +     set_bit(HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN, &hdev->quirks);
> > +
> >       return 0;
> > }
>
> Regards
>
> Marcel
>


-- 
Luiz Augusto von Dentz



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux