[bluez/bluez] 8fb8f9: gatt: Print error if gatt_db_attribut_notify fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Branch: refs/heads/master
  Home:   https://github.com/bluez/bluez
  Commit: 8fb8f9e73ff8b1f79c668fe1cfb2eb89e3599721
      https://github.com/bluez/bluez/commit/8fb8f9e73ff8b1f79c668fe1cfb2eb89e3599721
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-14 (Mon, 14 Mar 2022)

  Changed paths:
    M src/gatt-database.c

  Log Message:
  -----------
  gatt: Print error if gatt_db_attribut_notify fails

This prints an error if gatt_db_attribut_notify fails.


  Commit: 411d63ec33a23bdbad73276067d02f9981229d0b
      https://github.com/bluez/bluez/commit/411d63ec33a23bdbad73276067d02f9981229d0b
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-14 (Mon, 14 Mar 2022)

  Changed paths:
    M src/shared/gatt-db.c

  Log Message:
  -----------
  gatt-db: Fix gatt_db_attribute_notify

gatt_db_attribute_notify was only accepting passing the Characteristic
Declaration instead of accepting its value as well,
gatt_db_service_foreach_desc also have similar limitation so both have
been updated to allow working with both value and declaration.


  Commit: 41f8c466f3d558b7188470991dc61134f5ebd30d
      https://github.com/bluez/bluez/commit/41f8c466f3d558b7188470991dc61134f5ebd30d
  Author: Marcel Holtmann <marcel@xxxxxxxxxxxx>
  Date:   2022-03-16 (Wed, 16 Mar 2022)

  Changed paths:
    M ChangeLog
    M configure.ac

  Log Message:
  -----------
  Release 5.64


  Commit: a3c9409035deb20ce9d5535ce421f2bd252b92d9
      https://github.com/bluez/bluez/commit/a3c9409035deb20ce9d5535ce421f2bd252b92d9
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-23 (Wed, 23 Mar 2022)

  Changed paths:
    M src/log.h

  Log Message:
  -----------
  log: Don't log __FILE__ and __func__ with DBG_IDX

This removes __FILE__ and __func__ from DBG_IDX since users of it may
already contain such information embedded in the format.


  Commit: f9cb7c802f279aab8d49703282ddce4974ffcd26
      https://github.com/bluez/bluez/commit/f9cb7c802f279aab8d49703282ddce4974ffcd26
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-23 (Wed, 23 Mar 2022)

  Changed paths:
    M src/shared/mgmt.c

  Log Message:
  -----------
  mgmt: Add DBG macro

This adds mgmt_log wrapper for util_debug and DBG so file and function
names are printed with the logs.


  Commit: b7c807269f1f9260cc2c14ea542bdf79f9b657eb
      https://github.com/bluez/bluez/commit/b7c807269f1f9260cc2c14ea542bdf79f9b657eb
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-23 (Wed, 23 Mar 2022)

  Changed paths:
    M src/shared/mgmt.c
    M src/shared/mgmt.h

  Log Message:
  -----------
  mgmt: Introduce mgmt_set_verbose

This introduces mgmt_set_verbose which can be used to enable printing
the the likes hexdump of packets, by default it is disabled since in
most cases the hexdump is not very useful and there are better tools
to collect the hexdumo like btmon.


  Commit: 62c6037ea02b2d7dada43c1d7481fbe79f32dffb
      https://github.com/bluez/bluez/commit/62c6037ea02b2d7dada43c1d7481fbe79f32dffb
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-23 (Wed, 23 Mar 2022)

  Changed paths:
    M src/adapter.c

  Log Message:
  -----------
  adapter: Don't use DBG in mgmt_debug

mgmt_debug callback is used to print debug strings from mgmt instances
which includes the file and function names so using DBG would add yet
another set of file and function prefixes which makes the logs
confusing.


  Commit: 8039d42687fd89ee0aca5ef61c92c631a22a0295
      https://github.com/bluez/bluez/commit/8039d42687fd89ee0aca5ef61c92c631a22a0295
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-23 (Wed, 23 Mar 2022)

  Changed paths:
    M src/shared/att.c

  Log Message:
  -----------
  att: Log file and function names

This adds logging of file and function names.


  Commit: e0870ce5e1fe842e11f5d2a8425b4c4594ca0799
      https://github.com/bluez/bluez/commit/e0870ce5e1fe842e11f5d2a8425b4c4594ca0799
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-23 (Wed, 23 Mar 2022)

  Changed paths:
    M src/shared/gatt-client.c

  Log Message:
  -----------
  gatt-client: Add DBG macro

This adds gatt_log wrapper for util_debug and DBG macro so file and
function names are printed which is more consistent with other parts of
the daemon code.


  Commit: 55c25d91e4d6bb673e03064244890d40dc58e191
      https://github.com/bluez/bluez/commit/55c25d91e4d6bb673e03064244890d40dc58e191
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-23 (Wed, 23 Mar 2022)

  Changed paths:
    M src/shared/gatt-server.c

  Log Message:
  -----------
  gatt-server: Add DBG macro

This adds gatt_log wrapper for util_debug and DBG so file and function
names are printed with the logs.


  Commit: e1b808c128fa0f1a2a5e16387e3b026cf3d6ec83
      https://github.com/bluez/bluez/commit/e1b808c128fa0f1a2a5e16387e3b026cf3d6ec83
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-23 (Wed, 23 Mar 2022)

  Changed paths:
    M src/shared/att.c

  Log Message:
  -----------
  att: Rename att_debug and att_verbose to DBG and VERBOSE

att_debug and att_verbose are macros which are more common to be
used as uppercase, this also change them to use DBG like other parts of
the code.


  Commit: 71cec503c8da865ab1e74ea6716a8034264dcb48
      https://github.com/bluez/bluez/commit/71cec503c8da865ab1e74ea6716a8034264dcb48
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-23 (Wed, 23 Mar 2022)

  Changed paths:
    M src/device.c

  Log Message:
  -----------
  device: Don't use DBG in gatt_debug

gatt_debug callback is used to print debug strings from bt_att which
includes the file and function names so using DBG would add yet another
set of file and function prefixes which makes the logs confusing.


  Commit: 2a2b027176d5ed98483bf08ff335995502918d74
      https://github.com/bluez/bluez/commit/2a2b027176d5ed98483bf08ff335995502918d74
  Author: Inga Stotland <inga.stotland@xxxxxxxxx>
  Date:   2022-03-26 (Sat, 26 Mar 2022)

  Changed paths:
    M mesh/mesh-io-generic.c
    M mesh/mesh-io-unit.c

  Log Message:
  -----------
  mesh: Fix address overrun error in rx filter

This fixes the following error for invalid read access when registering
filter for incoming messages:

140632==ERROR: AddressSanitizer: stack-buffer-overflow on address...
 #0 0x7f60c185741d in MemcmpInterceptorCommon(...
    #1 0x7f60c1857af8 in __interceptor_memcmp (/lib64/libasan.so...
    #2 0x55a10101536e in find_by_filter mesh/mesh-io-unit.c:494
    #3 0x55a1010d8c46 in l_queue_remove_if ell/queue.c:517
    #4 0x55a101014ebd in recv_register mesh/mesh-io-unit.c:506
    #5 0x55a10102946f in mesh_net_attach mesh/net.c:2885
    #6 0x55a101086f64 in send_reply mesh/dbus.c:153
    #7 0x55a101124c3d in handle_method_return ell/dbus.c:216
    #8 0x55a10112c8ef in message_read_handler ell/dbus.c:276
    #9 0x55a1010dae20 in io_callback ell/io.c:120
    #10 0x55a1010dff7e in l_main_iterate ell/main.c:478
    #11 0x55a1010e06e3 in l_main_run ell/main.c:525
    #12 0x55a1010e06e3 in l_main_run ell/main.c:507
    #13 0x55a1010e0bfc in l_main_run_with_signal ell/main.c:647
    #14 0x55a10100316e in main mesh/main.c:292
    #15 0x7f60c0c6855f in __libc_start_call_main (/lib64/libc.so.6+...
    #16 0x7f60c0c6860b in __libc_start_main_alias_1 (/lib64/libc.so.6+...
    #17 0x55a101003ce4 in _start (/home/istotlan/bluez/mesh/bluetooth-m...


  Commit: 4fefa24097e45153f99cabbc70534d69a2a35ecd
      https://github.com/bluez/bluez/commit/4fefa24097e45153f99cabbc70534d69a2a35ecd
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-28 (Mon, 28 Mar 2022)

  Changed paths:
    M src/adapter.c

  Log Message:
  -----------
  adapter: Fix adding SDP records when operating on LE only mode

If mode is set to BT_MODE_LE SDP protocol won't be operational so it is
useless to attempt to add records.


  Commit: 18fc3abad28cccd2ac7e31963502973af8b86216
      https://github.com/bluez/bluez/commit/18fc3abad28cccd2ac7e31963502973af8b86216
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-28 (Mon, 28 Mar 2022)

  Changed paths:
    M profiles/audio/a2dp.c

  Log Message:
  -----------
  a2dp: Don't initialize a2dp_sep->destroy until properly registered

On a2dp_add_sep if the record cannot be properly registred
a2dp_unregister_sep would be called which would attempt to destroy the
user_data causing the following backtrace:

Invalid write of size 8
   at 0x2F41EB: endpoint_init_a2dp_source (media.c:687)
   by 0x2F41EB: media_endpoint_create (media.c:1030)
   by 0x2F6713: register_endpoint (media.c:1155)
   by 0x46983F: process_message (object.c:246)
   by 0x4A574A8: dbus_connection_dispatch (in /usr/lib64/libdbus-1.so.3.19.14)
   by 0x45F0BF: message_dispatch (mainloop.c:59)
   by 0x495239A: ??? (in /usr/lib64/libglib-2.0.so.0.7000.4)
   by 0x495605E: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.7000.4)
   by 0x49AB2A7: ??? (in /usr/lib64/libglib-2.0.so.0.7000.4)
   by 0x4955772: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.7000.4)
   by 0x4CA924: mainloop_run (mainloop-glib.c:66)
   by 0x4CAE1B: mainloop_run_with_signal (mainloop-notify.c:188)
   by 0x2AE791: main (main.c:1258)
 Address 0x6e47a30 is 0 bytes inside a block of size 112 free'd
   at 0x48470E4: free (vg_replace_malloc.c:872)
   by 0x4957CDC: g_free (in /usr/lib64/libglib-2.0.so.0.7000.4)
   by 0x2C2D57: a2dp_unregister_sep (a2dp.c:2588)
   by 0x2D124C: a2dp_add_sep (a2dp.c:2697)
   by 0x2F41D5: endpoint_init_a2dp_source (media.c:687)
   by 0x2F41D5: media_endpoint_create (media.c:1030)
   by 0x2F6713: register_endpoint (media.c:1155)
   by 0x46983F: process_message (object.c:246)
   by 0x4A574A8: dbus_connection_dispatch (in /usr/lib64/libdbus-1.so.3.19.14)
   by 0x45F0BF: message_dispatch (mainloop.c:59)
   by 0x495239A: ??? (in /usr/lib64/libglib-2.0.so.0.7000.4)
   by 0x495605E: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.7000.4)
   by 0x49AB2A7: ??? (in /usr/lib64/libglib-2.0.so.0.7000.4)


  Commit: 62e591578e3f948e187aacf44ede4286fad37ad7
      https://github.com/bluez/bluez/commit/62e591578e3f948e187aacf44ede4286fad37ad7
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-28 (Mon, 28 Mar 2022)

  Changed paths:
    M profiles/audio/a2dp.c

  Log Message:
  -----------
  a2dp: Always invalidate the cache if its configuration fails

When a configuration had been restored from last_used cache but it
fails invalidate it so another sep can be used.

Fixes: https://github.com/bluez/bluez/issues/313


  Commit: 6cb6e2ddf4471da365fe89ecd3c62454c9acf510
      https://github.com/bluez/bluez/commit/6cb6e2ddf4471da365fe89ecd3c62454c9acf510
  Author: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
  Date:   2022-03-28 (Mon, 28 Mar 2022)

  Changed paths:
    M src/shared/mgmt.c
    M src/shared/mgmt.h

  Log Message:
  -----------
  mgmt: Remove mgmt_set_verbose

The likes of btmon already decode the commands/events so there is no
need to have the code hexdump their contents.


Compare: https://github.com/bluez/bluez/compare/42e99371584c...6cb6e2ddf447



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux