Hi Marcel,
On Wed, Mar 23, 2022 at 3:37 AM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>
> Hi Luiz,
>
> > mgmt_debug callback is used to print debug strings from mgmt instances
> > which includes the file and function names so using DBG would add yet
> > another set of file and function prefixes which makes the logs
> > confusing.
> > ---
> > src/adapter.c | 8 +++-----
> > 1 file changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/src/adapter.c b/src/adapter.c
> > index 97ce26f8e..6680c5410 100644
> > --- a/src/adapter.c
> > +++ b/src/adapter.c
> > @@ -10327,9 +10327,8 @@ static void read_version_complete(uint8_t status, uint16_t length,
> >
> > static void mgmt_debug(const char *str, void *user_data)
> > {
> > - const char *prefix = user_data;
> > -
> > - info("%s%s", prefix, str);
> > + if (DBG_IS_ENABLED())
> > + btd_debug(0xffff, "%s", str);
> > }
> >
> > int adapter_init(void)
> > @@ -10342,8 +10341,7 @@ int adapter_init(void)
> > return -EIO;
> > }
> >
> > - if (getenv("MGMT_DEBUG"))
> > - mgmt_set_debug(mgmt_primary, mgmt_debug, "mgmt: ", NULL);
> > + mgmt_set_debug(mgmt_primary, mgmt_debug, NULL, NULL);
>
> oh no. This is crazy. Please re-think this and what computational overhead you are introducing.
I considered moving DBG_IS_ENABLED() in place of getenv("MGMT_DEBUG")
so that would be use just once per adapter, the problem is that
wouldn't work with:
case SIGUSR2:
__btd_toggle_debug();
Or perhaps I just need yet another match that adds the file and
function name so we can strip them out of DBG_IDX.
> Regards
>
> Marcel
>
--
Luiz Augusto von Dentz
