Re: [PATCH BlueZ] sixaxis: Fix Sony Navigation Controller pairing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jesse,

On Sun, Mar 13, 2022 at 7:46 PM Jesse Pullinen <jesse12p@xxxxxxxxx> wrote:
>
> Fixed the device name.
>
> Commit 61745d2bb8b5f534278db49faf8e2cdb7e894529
> ("sixaxis: Fix Bluetooth PS3 clone joypad being named like the original")
> made the matching use the name, which broke the pairing.
> ---
>  profiles/input/sixaxis.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/profiles/input/sixaxis.h b/profiles/input/sixaxis.h
> index ab8831995..cbd27cd06 100644
> --- a/profiles/input/sixaxis.h
> +++ b/profiles/input/sixaxis.h
> @@ -49,7 +49,7 @@ get_pairing(uint16_t vid, uint16_t pid, const char *name)
>                         .type = CABLE_PAIRING_SIXAXIS,
>                 },
>                 {
> -                       .name = "Navigation Controller",
> +                       .name = "Sony Navigation Controller",
>                         .source = 0x0002,
>                         .vid = 0x054c,
>                         .pid = 0x042f,
>
> base-commit: 42e99371584cc26c637fcc332de437d2c646f324
> --
> 2.35.1

Actually shouldn't we try to have another call to get_pairing if it
returns NULL to a specific name? That way the pid/vid is used as
fallback if the name doesn't match since the name perhaps can be set
by the user, or with a firmware update.


-- 
Luiz Augusto von Dentz



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux