Hi Marcel, thank you for reviewing the patches! Please read my replies in the lines below. Thanks! On Thu, Feb 17, 2022 at 8:13 PM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > > Hi Joseph, > > > Add the MGMT quality report command and event in doc/mgmt-api.txt. > > > > Signed-off-by: Joseph Hwang <josephsih@xxxxxxxxxxxx> > > --- > > > > Changes in v4: > > - Use "Quality Report Event" without the prefix "Bluetooth" word. > > - Combine both MGMT quality report command and event changes in a > > single patch. > > > > Changes in v3: > > - Swap AOSP Bluetooth Quality Report Event and Intel Telemetry Event. > > - Add 5 new patches (5/9 - 9/9) to enable the quality report > > feature via MGMT_OP_SET_QUALITY_REPORT instead of through the > > experimental features. > > > > Changes in v2: > > - This is a new patch for adding the event in doc/mgmt-api.txt > > > > doc/mgmt-api.txt | 61 ++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 61 insertions(+) > > > > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt > > index ebe56afa4..a494f5d7e 100644 > > --- a/doc/mgmt-api.txt > > +++ b/doc/mgmt-api.txt > > @@ -332,6 +332,7 @@ Read Controller Information Command > > 15 Static Address > > 16 PHY Configuration > > 17 Wideband Speech > > + 18 Quality Report > > > > This command generates a Command Complete event on success or > > a Command Status event on failure. > > @@ -2924,6 +2925,7 @@ Read Extended Controller Information Command > > 15 Static Address > > 16 PHY Configuration > > 17 Wideband Speech > > + 18 Quality Report > > > > The EIR_Data field contains information about class of device, > > local name and other values. Not all of them might be present. For > > @@ -3858,6 +3860,46 @@ Add Advertisement Patterns Monitor With RSSI Threshold Command > > Invalid Parameters > > > > > > +Set Quality Report Command > > +========================== > > + > > + Command Code: 0x0057 > > + Controller Index: <controller id> > > + Command Parameters: Action (1 Octet) > > I remember mentioning that we should use Quality_Report instead of Action. > > > + Return Parameters: Current_Settings (4 Octets) > > + > > + This command is used to enable and disable the controller's quality > > + report feature. The allowed values for the Action command parameter > > + are 0x00 and 0x01. All other values will return Invalid Parameters. > > + > > + The value 0x00 disables the Quality Report, and the value 0x01 > > + enables the Quality Report feature. > > + > > + This command is only available for the controllers that support > > + either AOSP Bluetooth quality report or Intel telemetry event. > > The details below are interesting, but don’t have to be in this document. It is supported if the Supported_Settings indicate support for it. > > > + For a controller supporting the AOSP specification, it should call > > + hci_set_aosp_capable() in its driver. The controller should also > > + return version_supported v0.98 or higher in its Vendor-specific > > + capabilities responding to the LE_Get_Vendor_Capabilities_Command. > > + On the other hand, for a controller supporting Intel specification, > > + it should set up the set_quality_report callback properly. The driver > > + is responsible of setting up the quality report capability as > > + described above; otherwise, a Not Supported status will be returned. > > + > > + This command requires to use a valid controller index. Otherwise, > > + an Invalid Index status will be returned. > > + > > + The command is sent to the controller to enable/disable the quality > > + report feature, and generates a Command Complete event on success. > > + If the controller failed to execute the action, a Failed status will > > + be returned. > > Can this be used when powered off, is it remembered over power off/on cycles etc. It is not remembered by the Intel controller over power cycles. I will test the other AOSP vendors, and plan to address this issue in separate patches in which I will describe the behavior explicitly. Thanks. > > > + > > + Possible errors: Failed > > + Invalid Index > > + Invalid Parameters > > + Not Supported > > + > > + > > Command Complete Event > > ====================== > > > > @@ -4978,3 +5020,22 @@ Advertisement Monitor Device Lost Event > > 2 LE Random > > > > This event will be sent to all management sockets. > > + > > + > > +Quality Report Event > > +==================== > > + > > + Event code: 0x0031 > > + Controller Index: <controller_id> > > + Event Parameters: Quality_Spec (1 Octet) > > + Report_Len (2 Octets) > > + Report (0-65535 Octets) > > + > > + This event carries the Bluetooth quality report sent by the > > + controller. > > + > > + Possible values for the Quality_Spec parameter: > > + 0 AOSP Bluetooth Quality Report Event > > + 1 Intel Telemetry Event > > + > > + This event will be sent to all management sockets. > > Regards > > Marcel > -- Joseph Shyh-In Hwang Email: josephsih@xxxxxxxxxx
