Re: [PATCH net-next] net: don't include ndisc.h from ipv6.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jakub,

> Nothing in ipv6.h needs ndisc.h, drop it.

Looks good, we lose the ARPHRD definitions without ndisc.h, but your
change to add if_arp.h addresses that:

> --- a/net/mctp/device.c
> +++ b/net/mctp/device.c
> @@ -6,6 +6,7 @@
>   * Copyright (c) 2021 Google
>   */
>  
> +#include <linux/if_arp.h>
>  #include <linux/if_link.h>
>  #include <linux/mctp.h>
>  #include <linux/netdevice.h>

So, for the net/mctp part:

Acked-by: Jeremy Kerr <jk@xxxxxxxxxxxxxxxxxxxx>

Cheers,


Jeremy




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux