Hi Marcel,
On Sat, Jan 8, 2022 at 6:41 AM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>
> Hi Jakub,
>
> >> The following changes since commit 710ad98c363a66a0cd8526465426c5c5f8377ee0:
> >>
> >> veth: Do not record rx queue hint in veth_xmit (2022-01-06 13:49:54 +0000)
> >>
> >> are available in the Git repository at:
> >>
> >> git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git tags/for-net-next-2022-01-07
> >>
> >> for you to fetch changes up to b9f9dbad0bd1c302d357fdd327c398f51f5fc2b1:
> >>
> >> Bluetooth: hci_sock: fix endian bug in hci_sock_setsockopt() (2022-01-07 08:41:38 +0100)
> >>
> >> ----------------------------------------------------------------
> >> bluetooth-next pull request for net-next:
> >>
> >> - Add support for Foxconn QCA 0xe0d0
> >> - Fix HCI init sequence on MacBook Air 8,1 and 8,2
> >> - Fix Intel firmware loading on legacy ROM devices
> >
> > A few warnings here that may be worth addressing - in particular this
> > one makes me feel that kbuild bot hasn't looked at the patches:
> >
> > net/bluetooth/hci_sync.c:5143:5: warning: no previous prototype for ‘hci_le_ext_create_conn_sync’ [-Wmissing-prototypes]
> > 5143 | int hci_le_ext_create_conn_sync(struct hci_dev *hdev, struct hci_conn *conn,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> this we have to fix with a patch since none of the commits were touching this. It really must have slipped through earlier.
Just sent a patch fixing the warning, once that is applied I will
create a new tag and send the pull request.
> > Also this Fixes tag could be mended:
> >
> > Commit: 6845667146a2 ("Bluetooth: hci_qca: Fix NULL vs IS_ERR_OR_NULL check in qca_serdev_probe")
> > Fixes tag: Fixes: 77131dfe ("Bluetooth: hci_qca: Replace devm_gpiod_get() with devm_gpiod_get_optional()")
> > Has these problem(s):
> > - SHA1 should be at least 12 digits long
> > Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > or later) just making sure it is not set (or set to "auto").
>
> I fixed that now and re-pushed the tree. Funny part is that I always check that the Fixes SHA1 is actually valid, but I never thought about checking that it is at least 12 digits long. I totally missed that and keep it in mind going forward.
>
> Regards
>
> Marcel
>
--
Luiz Augusto von Dentz
