Hi Paul, On Fri, Dec 17, 2021 at 7:33 AM Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote: > > Dear Tedd, > > > Am 16.12.21 um 19:38 schrieb An, Tedd: > > > On Thu, 2021-12-16 at 08:52 +0100, Paul Menzel wrote: > > >> Am 16.12.21 um 04:34 schrieb Tedd Ho-Jeong An: > >>> From: Tedd Ho-Jeong An <tedd.an@xxxxxxxxx> > >>> > >>> This patch fix the broken LED quirk for Intel legacy ROM devices. > >> > >> fix*es* > >> > >> Excuse my ignorance, but what are Intel legacy ROM devices? Maybe also > >> mention the IDs 0x0a2a and 0x0aa7 in the commit message? > >> > >>> Legacy device sends the SW RFKILL while shutting down the device (like > >>> HCI interface down) to turn off the LED by putting the device in assert. > >>> > >>> Once the SW RFKILL is on, it needs the HCI_Reset to exit from the SW > >>> RFKILL state. This patch checks the quirk and send the HCI_Reset before > >> > >> send*s* > >> > >>> sending the HCI_Intel_Read_Version command. > >> > >> Is that document in some datasheet/specification? If so, please mention it. > >> > >> Also, in the commit message summary you write “Fix”. If it fixes an old > >> commit, please add a Fixes: tag. > >> > >>> Signed-off-by: Tedd Ho-Jeong An <tedd.an@xxxxxxxxx> > >>> --- > >>> drivers/bluetooth/btintel.c | 13 ++++++------- > >>> drivers/bluetooth/btusb.c | 10 ++++++++-- > >>> 2 files changed, 14 insertions(+), 9 deletions(-) > >> > >> I have a Dell Latitude E7250 with the 8087:0a2a. How can I test this? > > > > Apply this patch on top of the bluetooth-next (or current mainline) > > The BT interface should be available after reboot. > > On the laptop, I do not have any problems with missing BT interface > after reboot with Linux 5.16-rc5. Are not all devices affected? If the problem is fixed for you please confirm it by replying with a Tested-by line. -- Luiz Augusto von Dentz
