On Tue, 30 Nov 2021 16:02:01 -0800 Luiz Augusto von Dentz wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> > > Like skb_pull but returns the original data pointer before pulling the > data after performing a check against sbk->len. > > This allows to change code that does "struct foo *p = (void *)skb->data;" > which is hard to audit and error prone, to: > > p = skb_pull_data(skb, sizeof(*p)); > if (!p) > return; > > Which is both safer and cleaner. It doesn't take a data pointer, so not really analogous to skb_put_data() and friends which come to mind. But I have no better naming suggestions. You will need to respin, tho, if you want us to apply these directly, the patches as posted don't apply to either netdev tree.