Re: [PATCH v1] Bluetooth: hci_qca: Stop IBS timer during BT OFF

[Marcel Holtmann <marcel@xxxxxxxxxxxx>]

Hi,

> This change stops IBS timers during BT OFF.
> 
> Signed-off-by: pharish <pharish@xxxxxxxxxxxxxx>

clear name please.

> ---
> drivers/bluetooth/hci_qca.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index dd768a8..6f44b26 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1928,6 +1928,9 @@ static int qca_power_off(struct hci_dev *hdev)
> 	hu->hdev->hw_error = NULL;
> 	hu->hdev->cmd_timeout = NULL;
> 
> +	mod_timer(&qca->tx_idle_timer, 0);
> +	mod_timer(&qca->wake_retrans_timer, 0);
> +

And I would really prefer if this gets changed to use a workqueue instead of a timer.

Regards

Marcel