Re: [PATCH v6 2/2] bluetooth: Add MGMT Adv Monitor Device Found/Lost events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Manish,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on next-20211118]
[cannot apply to bluetooth/master v5.16-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Manish-Mandlik/bluetooth-Handle-MSFT-Monitor-Device-Event/20211122-031347
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: hexagon-randconfig-r005-20211122 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c133fb321f7ca6083ce15b6aa5bf89de6600e649)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/b61f97a7820d3965cf6e5bbf719449c667bf1925
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Manish-Mandlik/bluetooth-Handle-MSFT-Monitor-Device-Event/20211122-031347
        git checkout b61f97a7820d3965cf6e5bbf719449c667bf1925
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=hexagon 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> net/bluetooth/mgmt.c:9601:6: warning: stack frame size (1120) exceeds limit (1024) in 'mgmt_device_found' [-Wframe-larger-than]
   void mgmt_device_found(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 link_type,
        ^
   1 warning generated.


vim +/mgmt_device_found +9601 net/bluetooth/mgmt.c

b61f97a7820d39 Manish Mandlik  2021-11-21  9600  
48f86b7f267335 Jakub Pawlowski 2015-03-04 @9601  void mgmt_device_found(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 link_type,
48f86b7f267335 Jakub Pawlowski 2015-03-04  9602  		       u8 addr_type, u8 *dev_class, s8 rssi, u32 flags,
48f86b7f267335 Jakub Pawlowski 2015-03-04  9603  		       u8 *eir, u16 eir_len, u8 *scan_rsp, u8 scan_rsp_len)
48f86b7f267335 Jakub Pawlowski 2015-03-04  9604  {
48f86b7f267335 Jakub Pawlowski 2015-03-04  9605  	char buf[512];
48f86b7f267335 Jakub Pawlowski 2015-03-04  9606  	struct mgmt_ev_device_found *ev = (void *)buf;
48f86b7f267335 Jakub Pawlowski 2015-03-04  9607  	size_t ev_size;
48f86b7f267335 Jakub Pawlowski 2015-03-04  9608  
48f86b7f267335 Jakub Pawlowski 2015-03-04  9609  	/* Don't send events for a non-kernel initiated discovery. With
48f86b7f267335 Jakub Pawlowski 2015-03-04  9610  	 * LE one exception is if we have pend_le_reports > 0 in which
48f86b7f267335 Jakub Pawlowski 2015-03-04  9611  	 * case we're doing passive scanning and want these events.
48f86b7f267335 Jakub Pawlowski 2015-03-04  9612  	 */
48f86b7f267335 Jakub Pawlowski 2015-03-04  9613  	if (!hci_discovery_active(hdev)) {
48f86b7f267335 Jakub Pawlowski 2015-03-04  9614  		if (link_type == ACL_LINK)
48f86b7f267335 Jakub Pawlowski 2015-03-04  9615  			return;
8208f5a9d435e5 Miao-chen Chou  2020-06-17  9616  		if (link_type == LE_LINK &&
8208f5a9d435e5 Miao-chen Chou  2020-06-17  9617  		    list_empty(&hdev->pend_le_reports) &&
8208f5a9d435e5 Miao-chen Chou  2020-06-17  9618  		    !hci_is_adv_monitoring(hdev)) {
48f86b7f267335 Jakub Pawlowski 2015-03-04  9619  			return;
48f86b7f267335 Jakub Pawlowski 2015-03-04  9620  		}
8208f5a9d435e5 Miao-chen Chou  2020-06-17  9621  	}
48f86b7f267335 Jakub Pawlowski 2015-03-04  9622  
82f8b651a94d5c Jakub Pawlowski 2015-03-04  9623  	if (hdev->discovery.result_filtering) {
48f86b7f267335 Jakub Pawlowski 2015-03-04  9624  		/* We are using service discovery */
48f86b7f267335 Jakub Pawlowski 2015-03-04  9625  		if (!is_filter_match(hdev, rssi, eir, eir_len, scan_rsp,
48f86b7f267335 Jakub Pawlowski 2015-03-04  9626  				     scan_rsp_len))
48f86b7f267335 Jakub Pawlowski 2015-03-04  9627  			return;
48f86b7f267335 Jakub Pawlowski 2015-03-04  9628  	}
48f86b7f267335 Jakub Pawlowski 2015-03-04  9629  
78b781ca0d3519 Johan Hedberg   2016-01-05  9630  	if (hdev->discovery.limited) {
78b781ca0d3519 Johan Hedberg   2016-01-05  9631  		/* Check for limited discoverable bit */
78b781ca0d3519 Johan Hedberg   2016-01-05  9632  		if (dev_class) {
78b781ca0d3519 Johan Hedberg   2016-01-05  9633  			if (!(dev_class[1] & 0x20))
78b781ca0d3519 Johan Hedberg   2016-01-05  9634  				return;
78b781ca0d3519 Johan Hedberg   2016-01-05  9635  		} else {
78b781ca0d3519 Johan Hedberg   2016-01-05  9636  			u8 *flags = eir_get_data(eir, eir_len, EIR_FLAGS, NULL);
78b781ca0d3519 Johan Hedberg   2016-01-05  9637  			if (!flags || !(flags[0] & LE_AD_LIMITED))
78b781ca0d3519 Johan Hedberg   2016-01-05  9638  				return;
78b781ca0d3519 Johan Hedberg   2016-01-05  9639  		}
78b781ca0d3519 Johan Hedberg   2016-01-05  9640  	}
78b781ca0d3519 Johan Hedberg   2016-01-05  9641  
48f86b7f267335 Jakub Pawlowski 2015-03-04  9642  	/* Make sure that the buffer is big enough. The 5 extra bytes
48f86b7f267335 Jakub Pawlowski 2015-03-04  9643  	 * are for the potential CoD field.
48f86b7f267335 Jakub Pawlowski 2015-03-04  9644  	 */
48f86b7f267335 Jakub Pawlowski 2015-03-04  9645  	if (sizeof(*ev) + eir_len + scan_rsp_len + 5 > sizeof(buf))
4b0e0ceddf085a Jakub Pawlowski 2015-02-01  9646  		return;
4b0e0ceddf085a Jakub Pawlowski 2015-02-01  9647  
48f86b7f267335 Jakub Pawlowski 2015-03-04  9648  	memset(buf, 0, sizeof(buf));
48f86b7f267335 Jakub Pawlowski 2015-03-04  9649  
48f86b7f267335 Jakub Pawlowski 2015-03-04  9650  	/* In case of device discovery with BR/EDR devices (pre 1.2), the
48f86b7f267335 Jakub Pawlowski 2015-03-04  9651  	 * RSSI value was reported as 0 when not available. This behavior
48f86b7f267335 Jakub Pawlowski 2015-03-04  9652  	 * is kept when using device discovery. This is required for full
48f86b7f267335 Jakub Pawlowski 2015-03-04  9653  	 * backwards compatibility with the API.
48f86b7f267335 Jakub Pawlowski 2015-03-04  9654  	 *
48f86b7f267335 Jakub Pawlowski 2015-03-04  9655  	 * However when using service discovery, the value 127 will be
48f86b7f267335 Jakub Pawlowski 2015-03-04  9656  	 * returned when the RSSI is not available.
48f86b7f267335 Jakub Pawlowski 2015-03-04  9657  	 */
48f86b7f267335 Jakub Pawlowski 2015-03-04  9658  	if (rssi == HCI_RSSI_INVALID && !hdev->discovery.report_invalid_rssi &&
48f86b7f267335 Jakub Pawlowski 2015-03-04  9659  	    link_type == ACL_LINK)
48f86b7f267335 Jakub Pawlowski 2015-03-04  9660  		rssi = 0;
48f86b7f267335 Jakub Pawlowski 2015-03-04  9661  
48f86b7f267335 Jakub Pawlowski 2015-03-04  9662  	bacpy(&ev->addr.bdaddr, bdaddr);
48f86b7f267335 Jakub Pawlowski 2015-03-04  9663  	ev->addr.type = link_to_bdaddr(link_type, addr_type);
48f86b7f267335 Jakub Pawlowski 2015-03-04  9664  	ev->rssi = rssi;
48f86b7f267335 Jakub Pawlowski 2015-03-04  9665  	ev->flags = cpu_to_le32(flags);
48f86b7f267335 Jakub Pawlowski 2015-03-04  9666  
48f86b7f267335 Jakub Pawlowski 2015-03-04  9667  	if (eir_len > 0)
48f86b7f267335 Jakub Pawlowski 2015-03-04  9668  		/* Copy EIR or advertising data into event */
48f86b7f267335 Jakub Pawlowski 2015-03-04  9669  		memcpy(ev->eir, eir, eir_len);
48f86b7f267335 Jakub Pawlowski 2015-03-04  9670  
0d3b7f64c84d53 Johan Hedberg   2016-01-05  9671  	if (dev_class && !eir_get_data(ev->eir, eir_len, EIR_CLASS_OF_DEV,
0d3b7f64c84d53 Johan Hedberg   2016-01-05  9672  				       NULL))
48f86b7f267335 Jakub Pawlowski 2015-03-04  9673  		eir_len = eir_append_data(ev->eir, eir_len, EIR_CLASS_OF_DEV,
48f86b7f267335 Jakub Pawlowski 2015-03-04  9674  					  dev_class, 3);
48f86b7f267335 Jakub Pawlowski 2015-03-04  9675  
48f86b7f267335 Jakub Pawlowski 2015-03-04  9676  	if (scan_rsp_len > 0)
48f86b7f267335 Jakub Pawlowski 2015-03-04  9677  		/* Append scan response data to event */
48f86b7f267335 Jakub Pawlowski 2015-03-04  9678  		memcpy(ev->eir + eir_len, scan_rsp, scan_rsp_len);
48f86b7f267335 Jakub Pawlowski 2015-03-04  9679  
5d2e9fadf43e87 Johan Hedberg   2014-03-25  9680  	ev->eir_len = cpu_to_le16(eir_len + scan_rsp_len);
5d2e9fadf43e87 Johan Hedberg   2014-03-25  9681  	ev_size = sizeof(*ev) + eir_len + scan_rsp_len;
f8523598ee608a Andre Guedes    2011-09-09  9682  
b61f97a7820d39 Manish Mandlik  2021-11-21  9683  	/* We have received the Advertisement Report because:
b61f97a7820d39 Manish Mandlik  2021-11-21  9684  	 * 1. the kernel has initiated active discovery
b61f97a7820d39 Manish Mandlik  2021-11-21  9685  	 * 2. if not, we have pend_le_reports > 0 in which case we are doing
b61f97a7820d39 Manish Mandlik  2021-11-21  9686  	 *    passive scanning
b61f97a7820d39 Manish Mandlik  2021-11-21  9687  	 * 3. if none of the above is true, we have one or more active
b61f97a7820d39 Manish Mandlik  2021-11-21  9688  	 *    Advertisement Monitor
b61f97a7820d39 Manish Mandlik  2021-11-21  9689  	 *
b61f97a7820d39 Manish Mandlik  2021-11-21  9690  	 * For case 1 and 2, report all advertisements via MGMT_EV_DEVICE_FOUND
b61f97a7820d39 Manish Mandlik  2021-11-21  9691  	 * and report ONLY one advertisement per device for the matched Monitor
b61f97a7820d39 Manish Mandlik  2021-11-21  9692  	 * via MGMT_EV_ADV_MONITOR_DEVICE_FOUND event.
b61f97a7820d39 Manish Mandlik  2021-11-21  9693  	 *
b61f97a7820d39 Manish Mandlik  2021-11-21  9694  	 * For case 3, since we are not active scanning and all advertisements
b61f97a7820d39 Manish Mandlik  2021-11-21  9695  	 * received are due to a matched Advertisement Monitor, report all
b61f97a7820d39 Manish Mandlik  2021-11-21  9696  	 * advertisements ONLY via MGMT_EV_ADV_MONITOR_DEVICE_FOUND event.
b61f97a7820d39 Manish Mandlik  2021-11-21  9697  	 */
b61f97a7820d39 Manish Mandlik  2021-11-21  9698  
b61f97a7820d39 Manish Mandlik  2021-11-21  9699  	if (hci_discovery_active(hdev) ||
b61f97a7820d39 Manish Mandlik  2021-11-21  9700  	    (link_type == LE_LINK && !list_empty(&hdev->pend_le_reports))) {
901801b9a420e5 Marcel Holtmann 2013-10-06  9701  		mgmt_event(MGMT_EV_DEVICE_FOUND, hdev, ev, ev_size, NULL);
b61f97a7820d39 Manish Mandlik  2021-11-21  9702  
b61f97a7820d39 Manish Mandlik  2021-11-21  9703  		if (hdev->advmon_pend_notify)
b61f97a7820d39 Manish Mandlik  2021-11-21  9704  			mgmt_adv_monitor_device_found(hdev, ev, ev_size, true);
b61f97a7820d39 Manish Mandlik  2021-11-21  9705  	} else {
b61f97a7820d39 Manish Mandlik  2021-11-21  9706  		mgmt_adv_monitor_device_found(hdev, ev, ev_size, false);
b61f97a7820d39 Manish Mandlik  2021-11-21  9707  	}
e17acd40f6006d Johan Hedberg   2011-03-30  9708  }
a88a9652d25a63 Johan Hedberg   2011-03-30  9709  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux