Hi Manish, On Wed, Nov 17, 2021 at 11:15 AM Manish Mandlik <mmandlik@xxxxxxxxxx> wrote: > > Update default Advertisemet Monitor Sampling_Period to 0xFF. It > indicates that controller will report only one advertisement per > monitoring period for a device. This will help reduce the power > consumption drastically. > > Reviewed-by: Miao-chen Chou <mcchou@xxxxxxxxxx> > --- > > Changes in v5: > - New patch in the series. Update default Sampling_Period to 0xFF. > > src/main.c | 2 +- > src/main.conf | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/main.c b/src/main.c > index 5ca8d5644..1f852fdf6 100644 > --- a/src/main.c > +++ b/src/main.c > @@ -932,7 +932,7 @@ static void init_defaults(void) > btd_opts.avdtp.session_mode = BT_IO_MODE_BASIC; > btd_opts.avdtp.stream_mode = BT_IO_MODE_BASIC; > > - btd_opts.advmon.rssi_sampling_period = 0; > + btd_opts.advmon.rssi_sampling_period = 0xFF; > } > > static void log_handler(const gchar *log_domain, GLogLevelFlags log_level, > diff --git a/src/main.conf b/src/main.conf > index e05291d8e..e49259453 100644 > --- a/src/main.conf > +++ b/src/main.conf > @@ -260,5 +260,5 @@ > [AdvMon] > # Default RSSI Sampling Period. This is used when a client registers an > # advertisement monitor and leaves the RSSISamplingPeriod unset. > -# Default: 0 > +# Default: 0xFF (Report only one Adv per device during the monitoring period) > #RSSISamplingPeriod=0 While at it it would be good to explain what is the unit used here, also it is common practice to have the default on the commented entry. > -- > 2.34.0.rc1.387.gb447b232ab-goog > -- Luiz Augusto von Dentz
