+Mark-YW.Chen@xxxxxxxxxxxx Some of Mediatek's controllers/firmwares do NOT support AOSP extensions. Please refer to this Gerrit patch review link for chrome os (https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3054233/8/drivers/bluetooth/btusb.c) which was reviewed by Mark-YW Chen, Mediatek's engineer. As an example, MediaTek MT7615E does not support the AOSP extensions. That was why I used a new BTUSB_QUALITY_REPORT flag in the changes v4 and earlier ones. Please let me know how you would like to proceed with this patch. Thanks! Joseph On Mon, Oct 25, 2021 at 9:26 PM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > > Hi Joseph, > > > This patch enables Mediatek to support the AOSP extension. > > > > Reviewed-by: Miao-chen Chou <mcchou@xxxxxxxxxxxx> > > Signed-off-by: Joseph Hwang <josephsih@xxxxxxxxxxxx> > > > > --- > > > > (no changes since v5) > > > > Changes in v5: > > - Let the vendor command in aosp_do_open() to determine what > > capabilities are supported. > > > > Changes in v4: > > - Call hci_set_aosp_capable in the driver. > > - This patch is added in this Series-changes 4. > > > > drivers/bluetooth/btusb.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > > index 87b71740fad8..00311ebd7823 100644 > > --- a/drivers/bluetooth/btusb.c > > +++ b/drivers/bluetooth/btusb.c > > @@ -3876,6 +3876,8 @@ static int btusb_probe(struct usb_interface *intf, > > hdev->set_bdaddr = btusb_set_bdaddr_mtk; > > set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks); > > data->recv_acl = btusb_recv_acl_mtk; > > + > > + hci_set_aosp_capable(hdev); > > can we get an ACK from Mediatek people that all their firmwares support the AOSP extensions. > > Regards > > Marcel > -- Joseph Shyh-In Hwang Email: josephsih@xxxxxxxxxx
