Hi Tedd, Manish, On Thu, Oct 14, 2021 at 10:36 PM <bluez.test.bot@xxxxxxxxx> wrote: > > This is automated email and please do not reply to this email! > > Dear submitter, > > Thank you for submitting the patches to the linux bluetooth mailing list. > This is a CI test results with your patch series: > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=563859 Do you guys have any comments on this set? Id like to push it but I haven't been able to validate if the PDU definitions, etc, are set properly. > ---Test result--- > > Test Summary: > CheckPatch FAIL 4.45 seconds > GitLint FAIL 2.34 seconds > Prep - Setup ELL PASS 56.30 seconds > Build - Prep PASS 0.25 seconds > Build - Configure PASS 10.00 seconds > Build - Make PASS 238.32 seconds > Make Check PASS 9.34 seconds > Make Distcheck PASS 279.48 seconds > Build w/ext ELL - Configure PASS 10.29 seconds > Build w/ext ELL - Make PASS 226.33 seconds > > Details > ############################## > Test: CheckPatch - FAIL > Desc: Run checkpatch.pl script with rule in .checkpatch.conf > Output: > [BlueZ,1/7] monitor: Add packet definitions for MSFT extension > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #101: FILE: monitor/msft.h:31: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #109: FILE: monitor/msft.h:39: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #120: FILE: monitor/msft.h:50: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #125: FILE: monitor/msft.h:55: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #132: FILE: monitor/msft.h:62: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #137: FILE: monitor/msft.h:67: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #146: FILE: monitor/msft.h:76: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #151: FILE: monitor/msft.h:81: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #160: FILE: monitor/msft.h:90: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #164: FILE: monitor/msft.h:94: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #170: FILE: monitor/msft.h:100: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #180: FILE: monitor/msft.h:110: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #186: FILE: monitor/msft.h:116: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #193: FILE: monitor/msft.h:123: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #198: FILE: monitor/msft.h:128: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #205: FILE: monitor/msft.h:135: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #210: FILE: monitor/msft.h:140: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #217: FILE: monitor/msft.h:147: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #224: FILE: monitor/msft.h:154: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #233: FILE: monitor/msft.h:163: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #243: FILE: monitor/msft.h:173: > +} __attribute__((packed)); > > /github/workspace/src/12560019.patch total: 0 errors, 21 warnings, 154 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > /github/workspace/src/12560019.patch has style problems, please review. > > NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > [BlueZ,3/7] vhci: Read the controller index > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #173: FILE: emulator/vhci.c:95: > +} __attribute__((packed)); > > WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) > #179: FILE: emulator/vhci.c:101: > +} __attribute__((packed)); > > /github/workspace/src/12560021.patch total: 0 errors, 2 warnings, 172 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > /github/workspace/src/12560021.patch has style problems, please review. > > NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > [BlueZ,5/7] hciemu: Use vhci_open to instanciate a vhci btdev > WARNING:TYPO_SPELLING: 'instanciate' may be misspelled - perhaps 'instantiate'? > #72: > Subject: [PATCH BlueZ 5/7] hciemu: Use vhci_open to instanciate a vhci btdev > ^^^^^^^^^^^ > > /github/workspace/src/12560027.patch total: 0 errors, 1 warnings, 355 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > /github/workspace/src/12560027.patch has style problems, please review. > > NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > > ############################## > Test: GitLint - FAIL > Desc: Run gitlint with rule in .gitlint > Output: > [BlueZ,7/7] mgmt-tester: Make use of vhci_set_force_suspend/vhci_set_force_wakeup > 1: T1 Title exceeds max length (81>80): "[BlueZ,7/7] mgmt-tester: Make use of vhci_set_force_suspend/vhci_set_force_wakeup" > > > > > --- > Regards, > Linux Bluetooth > -- Luiz Augusto von Dentz