Hi Luiz, >>> This adds a debugfs entries to set msft_opcode and aosp_capable enabling >>> vhci to emulate controllers with MSFT/AOSP extension support. >>> >>> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> >>> --- >>> v2: Fix typos: s/extention/extension/g >>> v3: Remove checks for HCI_SETUP, merge changes to introduce MSFT/AOSP support >>> at the same time. >>> >>> drivers/bluetooth/hci_vhci.c | 92 ++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 92 insertions(+) >> >> patch has been applied to bluetooth-next tree (with slight modifications). > > ++<<<<<<< HEAD > + hci_set_msft_opcode(hdev, vhci->msft_opcode); > + hci_set_aosp_capable(hdev); > ++======= > + if (vhci->msft_opcode) > + hci_set_msft_opcode(hdev, vhci->msft_opcode); > + > + if (vhci->aosp_capable) > + hci_set_aosp_capable(hdev); > ++>>>>>>> 9bbbb6a7ad09 (Bluetooth: vhci: Add support for setting > msft_opcode and aosp_capable) > > I suspect the above changes won't work if we don't init the fields in > the vhci_data, msft_opcode would be set to 0x0000 so it won't be > enabled anyway but aosp_capable would be enabled which would be out of > sync with vhci->aosp_capable, so perhaps we want to change > hci_set_aosp_capable to take a parameter: I went to bed yesterday and today, I realized that I have done something stupid. I fixed this upstream and also made sure that you can only ever set this once per debugfs. Regards Marcel
