Re: [RFC PATCH] Bluetooth: hci_sock: Set flag to all sockets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel

On Fri, 2021-10-01 at 07:43 +0200, Marcel Holtmann wrote:
> Hi Tedd,
> 
> > The mgmt_limited_event() send the event to the socket that matches the
> > flag type, but also it skips to the given socket object in the
> > parameter.
> > 
> > For Local Out of Band Data Updated Event and Experimental Feature
> > Changed Event, it sets flags only for the socket which the change was
> > triggered, the event cannot be sent to the client via any sockets
> > because the flag is not set for other sockets and it doens't send to the
> > socket which the change was triggered.
> > 
> > This patch adds the function that sets the flag for all available
> > management sockets, so the mgmt_limited_event() still can send the event
> > to the management sockets other than the one through which the change
> > was triggered.
> 
> actually that is on purpose. Only the socket that used a specific mgmt commands gets to see the
> new events. So if you have a second listening socket that just cares about the events, it has to
> at least issue the “read” command to tell mgmt that it does understand it. There is no point in
> sending out signals to all mgmt sockets if you haven’t read an initial status first. The updates
> would make no sense to you.
> 
Thanks for the details. And the code make sense now. Need to update mgmt-tester with these then.

> Regards
> 
> Marcel
> 

Regards,

Tedd




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux