From: Archie Pusaka <apusaka@xxxxxxxxxxxx> "accept list" and "reject list" are the preferred terms, as reflected in the BT core spec 5.3, also in https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf --- src/adapter.c | 18 ++++++++++-------- src/adapter.h | 4 ++-- src/device.c | 6 +++--- 3 files changed, 15 insertions(+), 13 deletions(-) diff --git a/src/adapter.c b/src/adapter.c index a23c438f34..3ed785bf08 100644 --- a/src/adapter.c +++ b/src/adapter.c @@ -4957,7 +4957,7 @@ void adapter_connect_list_remove(struct btd_adapter *adapter, trigger_passive_scanning(adapter); } -static void add_whitelist_complete(uint8_t status, uint16_t length, +static void add_accept_list_complete(uint8_t status, uint16_t length, const void *param, void *user_data) { const struct mgmt_rp_add_device *rp = param; @@ -4988,10 +4988,11 @@ static void add_whitelist_complete(uint8_t status, uint16_t length, return; } - DBG("%s added to kernel whitelist", addr); + DBG("%s added to kernel accept list", addr); } -void adapter_whitelist_add(struct btd_adapter *adapter, struct btd_device *dev) +void adapter_accept_list_add(struct btd_adapter *adapter, + struct btd_device *dev) { struct mgmt_cp_add_device cp; @@ -5005,10 +5006,10 @@ void adapter_whitelist_add(struct btd_adapter *adapter, struct btd_device *dev) mgmt_send(adapter->mgmt, MGMT_OP_ADD_DEVICE, adapter->dev_id, sizeof(cp), &cp, - add_whitelist_complete, adapter, NULL); + add_accept_list_complete, adapter, NULL); } -static void remove_whitelist_complete(uint8_t status, uint16_t length, +static void remove_accept_list_complete(uint8_t status, uint16_t length, const void *param, void *user_data) { const struct mgmt_rp_remove_device *rp = param; @@ -5027,10 +5028,11 @@ static void remove_whitelist_complete(uint8_t status, uint16_t length, return; } - DBG("%s removed from kernel whitelist", addr); + DBG("%s removed from kernel accept list", addr); } -void adapter_whitelist_remove(struct btd_adapter *adapter, struct btd_device *dev) +void adapter_accept_list_remove(struct btd_adapter *adapter, + struct btd_device *dev) { struct mgmt_cp_remove_device cp; @@ -5043,7 +5045,7 @@ void adapter_whitelist_remove(struct btd_adapter *adapter, struct btd_device *de mgmt_send(adapter->mgmt, MGMT_OP_REMOVE_DEVICE, adapter->dev_id, sizeof(cp), &cp, - remove_whitelist_complete, adapter, NULL); + remove_accept_list_complete, adapter, NULL); } static void add_device_complete(uint8_t status, uint16_t length, diff --git a/src/adapter.h b/src/adapter.h index 60b5e3bcca..19e7cf82ad 100644 --- a/src/adapter.h +++ b/src/adapter.h @@ -214,9 +214,9 @@ void adapter_auto_connect_add(struct btd_adapter *adapter, struct btd_device *device); void adapter_auto_connect_remove(struct btd_adapter *adapter, struct btd_device *device); -void adapter_whitelist_add(struct btd_adapter *adapter, +void adapter_accept_list_add(struct btd_adapter *adapter, struct btd_device *dev); -void adapter_whitelist_remove(struct btd_adapter *adapter, +void adapter_accept_list_remove(struct btd_adapter *adapter, struct btd_device *dev); void btd_adapter_set_oob_handler(struct btd_adapter *adapter, diff --git a/src/device.c b/src/device.c index b29aa195d1..4997d6ab6d 100644 --- a/src/device.c +++ b/src/device.c @@ -1122,7 +1122,7 @@ static void set_blocked(GDBusPendingPropertySet id, gboolean value, void *data) break; case EINVAL: g_dbus_pending_property_error(id, ERROR_INTERFACE ".Failed", - "Kernel lacks blacklist support"); + "Kernel lacks reject list support"); break; default: g_dbus_pending_property_error(id, ERROR_INTERFACE ".Failed", @@ -5714,7 +5714,7 @@ void btd_device_set_temporary(struct btd_device *device, bool temporary) if (temporary) { if (device->bredr) - adapter_whitelist_remove(device->adapter, device); + adapter_accept_list_remove(device->adapter, device); adapter_connect_list_remove(device->adapter, device); if (device->auto_connect) { device->disable_auto_connect = TRUE; @@ -5726,7 +5726,7 @@ void btd_device_set_temporary(struct btd_device *device, bool temporary) clear_temporary_timer(device); if (device->bredr) - adapter_whitelist_add(device->adapter, device); + adapter_accept_list_add(device->adapter, device); store_device_info(device); -- 2.33.0.rc1.237.g0d66db33f3-goog