This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=523089 ---Test result--- Test Summary: CheckPatch FAIL 4.21 seconds GitLint PASS 1.59 seconds Prep - Setup ELL PASS 47.01 seconds Build - Prep PASS 0.11 seconds Build - Configure PASS 8.40 seconds Build - Make FAIL 152.72 seconds Make Check FAIL 0.52 seconds Make Distcheck PASS 242.04 seconds Build w/ext ELL - Configure PASS 8.44 seconds Build w/ext ELL - Make FAIL 140.34 seconds Details ############################## Test: CheckPatch - FAIL Desc: Run checkpatch.pl script with rule in .checkpatch.conf Output: mcap: add adapter authorization WARNING:NEW_TYPEDEFS: do not add new typedefs #152: FILE: profiles/health/mcap.h:253: +typedef guint (* mcap_authorize_cb) (const bdaddr_t *src, const bdaddr_t *dst, WARNING:LONG_LINE_COMMENT: line length of 93 exceeds 80 columns #163: FILE: profiles/health/mcap.h:279: + mcap_authorize_cb authorize_cb; /* Method to request authorization */ - total: 0 errors, 2 warnings, 141 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] mcap: add adapter authorization" has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. core: add device_added and device_removed to adapter driver WARNING:SPACING: Unnecessary space before function pointer arguments #130: FILE: src/adapter.h:114: + void (*device_added) (struct btd_adapter *adapter, WARNING:SPACING: Unnecessary space before function pointer arguments #132: FILE: src/adapter.h:116: + void (*device_removed) (struct btd_adapter *adapter, - total: 0 errors, 2 warnings, 112 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] core: add device_added and device_removed to adapter driver" has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. plugins/admin: add ServiceAllowList property ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #63: FILE: plugins/admin.c:186: + const GDBusPropertyTable *property, ^ - total: 1 errors, 0 warnings, 82 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] plugins/admin: add ServiceAllowList property" has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. plugins/admin: add AffectedByPolicy property ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #65: FILE: plugins/admin.c:254: + const GDBusPropertyTable *property, ^ - total: 1 errors, 0 warnings, 121 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] plugins/admin: add AffectedByPolicy property" has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. plugins/admin: persist policy settings WARNING:LINE_SPACING: Missing a blank line after declarations #151: FILE: plugins/admin.c:336: + struct queue *uuid_list = NULL; + gchar **uuids = NULL; - total: 0 errors, 1 warnings, 204 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] plugins/admin: persist policy settings" has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ############################## Test: GitLint - PASS Desc: Run gitlint with rule in .gitlint ############################## Test: Prep - Setup ELL - PASS Desc: Clone, build, and install ELL ############################## Test: Build - Prep - PASS Desc: Prepare environment for build ############################## Test: Build - Configure - PASS Desc: Configure the BlueZ source tree ############################## Test: Build - Make - FAIL Desc: Build the BlueZ source tree Output: plugins/admin.c:211:6: error: no previous declaration for ‘append_service_uuid’ [-Werror=missing-declarations] 211 | void append_service_uuid(void *data, void *user_data) | ^~~~~~~~~~~~~~~~~~~ plugins/admin.c: In function ‘free_uuid_strings’: plugins/admin.c:252:16: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare] 252 | for (i = 0; i < num; i++) | ^ plugins/admin.c: In function ‘store_policy_settings’: plugins/admin.c:317:26: error: ‘errno’ undeclared (first use in this function) 317 | filename, strerror(errno)); | ^~~~~ plugins/admin.c:32:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’? 31 | #include "src/shared/queue.h" +++ |+#include <errno.h> 32 | plugins/admin.c:317:26: note: each undeclared identifier is reported only once for each function it appears in 317 | filename, strerror(errno)); | ^~~~~ plugins/admin.c: In function ‘property_get_affected_by_policy’: plugins/admin.c:418:14: error: unused variable ‘affected’ [-Werror=unused-variable] 418 | dbus_bool_t affected; | ^~~~~~~~ plugins/admin.c: In function ‘admin_policy_adapter_probe’: plugins/admin.c:467:11: error: ‘ENOMEM’ undeclared (first use in this function) 467 | return -ENOMEM; | ^~~~~~ plugins/admin.c:479:11: error: ‘EINVAL’ undeclared (first use in this function) 479 | return -EINVAL; | ^~~~~~ cc1: all warnings being treated as errors make[1]: *** [Makefile:8449: plugins/bluetoothd-admin.o] Error 1 make: *** [Makefile:4147: all] Error 2 ############################## Test: Make Check - FAIL Desc: Run 'make check' Output: plugins/admin.c:211:6: error: no previous declaration for ‘append_service_uuid’ [-Werror=missing-declarations] 211 | void append_service_uuid(void *data, void *user_data) | ^~~~~~~~~~~~~~~~~~~ plugins/admin.c: In function ‘free_uuid_strings’: plugins/admin.c:252:16: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare] 252 | for (i = 0; i < num; i++) | ^ plugins/admin.c: In function ‘store_policy_settings’: plugins/admin.c:317:26: error: ‘errno’ undeclared (first use in this function) 317 | filename, strerror(errno)); | ^~~~~ plugins/admin.c:32:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’? 31 | #include "src/shared/queue.h" +++ |+#include <errno.h> 32 | plugins/admin.c:317:26: note: each undeclared identifier is reported only once for each function it appears in 317 | filename, strerror(errno)); | ^~~~~ plugins/admin.c: In function ‘property_get_affected_by_policy’: plugins/admin.c:418:14: error: unused variable ‘affected’ [-Werror=unused-variable] 418 | dbus_bool_t affected; | ^~~~~~~~ plugins/admin.c: In function ‘admin_policy_adapter_probe’: plugins/admin.c:467:11: error: ‘ENOMEM’ undeclared (first use in this function) 467 | return -ENOMEM; | ^~~~~~ plugins/admin.c:479:11: error: ‘EINVAL’ undeclared (first use in this function) 479 | return -EINVAL; | ^~~~~~ cc1: all warnings being treated as errors make[1]: *** [Makefile:8449: plugins/bluetoothd-admin.o] Error 1 make: *** [Makefile:10436: check] Error 2 ############################## Test: Make Distcheck - PASS Desc: Run distcheck to check the distribution ############################## Test: Build w/ext ELL - Configure - PASS Desc: Configure BlueZ source with '--enable-external-ell' configuration ############################## Test: Build w/ext ELL - Make - FAIL Desc: Build BlueZ source with '--enable-external-ell' configuration Output: plugins/admin.c:211:6: error: no previous declaration for ‘append_service_uuid’ [-Werror=missing-declarations] 211 | void append_service_uuid(void *data, void *user_data) | ^~~~~~~~~~~~~~~~~~~ plugins/admin.c: In function ‘free_uuid_strings’: plugins/admin.c:252:16: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare] 252 | for (i = 0; i < num; i++) | ^ plugins/admin.c: In function ‘store_policy_settings’: plugins/admin.c:317:26: error: ‘errno’ undeclared (first use in this function) 317 | filename, strerror(errno)); | ^~~~~ plugins/admin.c:32:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’? 31 | #include "src/shared/queue.h" +++ |+#include <errno.h> 32 | plugins/admin.c:317:26: note: each undeclared identifier is reported only once for each function it appears in 317 | filename, strerror(errno)); | ^~~~~ plugins/admin.c: In function ‘property_get_affected_by_policy’: plugins/admin.c:418:14: error: unused variable ‘affected’ [-Werror=unused-variable] 418 | dbus_bool_t affected; | ^~~~~~~~ plugins/admin.c: In function ‘admin_policy_adapter_probe’: plugins/admin.c:467:11: error: ‘ENOMEM’ undeclared (first use in this function) 467 | return -ENOMEM; | ^~~~~~ plugins/admin.c:479:11: error: ‘EINVAL’ undeclared (first use in this function) 479 | return -EINVAL; | ^~~~~~ cc1: all warnings being treated as errors make[1]: *** [Makefile:8449: plugins/bluetoothd-admin.o] Error 1 make: *** [Makefile:4147: all] Error 2 --- Regards, Linux Bluetooth
