Hi Marcel, On Thu, 22 Jul 2021 at 22:32, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > > Hi Archie, > > > Some RTL chips resets the FW on suspend, so wakeup is disabled on > > those chips. This patch introduces this WAKEUP_DISABLE flag so that > > chips that doesn't reset FW on suspend can leave the flag unset and > > is allowed to wake the host. > > > > This patch also left RTL8822 WAKEUP_DISABLE flag unset, therefore > > allowing it to wake the host, and preventing reprobing on resume. > > > > Signed-off-by: Archie Pusaka <apusaka@xxxxxxxxxxxx> > > Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@xxxxxxxxxxxx> > > Reviewed-by: Hilda Wu <hildawu@xxxxxxxxxxx> > > > > --- > > > > Changes in v2: > > * Remove unnecessary variable > > > > drivers/bluetooth/hci_h5.c | 83 +++++++++++++++++++++++++++----------- > > 1 file changed, 59 insertions(+), 24 deletions(-) > > so the set does not apply cleanly to bluetooth-next > > Applying: Bluetooth: hci_h5: Add runtime suspend > error: patch failed: drivers/bluetooth/hci_h5.c:11 > error: drivers/bluetooth/hci_h5.c: patch does not apply Hmm, it applies cleanly for me. Not sure what's going on. Anyway I rebased and made a little change as v3, please take a look! > > > And I am really close to not accepting any patches for hci_h5.c anymore. This thing turns into crazy hacking and nobody is taking my hint to redo this as clean H:5 3-Wire serdev standalone driver. Pardon my unfamiliarity, but could you share more about your vision of a clean h5 driver? Should the RTL component be moved out to btrtl? Do we have something as a reference? > > Regards > > Marcel > Thanks, Archie
