This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=517051 ---Test result--- Test Summary: CheckPatch FAIL 1.55 seconds GitLint FAIL 0.49 seconds Prep - Setup ELL PASS 47.28 seconds Build - Prep PASS 0.11 seconds Build - Configure PASS 8.39 seconds Build - Make PASS 204.40 seconds Make Check PASS 9.50 seconds Make Distcheck PASS 248.76 seconds Build w/ext ELL - Configure PASS 9.13 seconds Build w/ext ELL - Make PASS 192.09 seconds Details ############################## Test: CheckPatch - FAIL Desc: Run checkpatch.pl script with rule in .checkpatch.conf Output: obexd: phonebook-ebook: modernize WARNING:LONG_LINE: line length of 87 exceeds 80 columns #145: FILE: obexd/plugins/phonebook-ebook.c:138: + e_vcard_add_attribute(evcard2, e_vcard_attribute_copy(attrib)); WARNING:LONG_LINE_COMMENT: line length of 102 exceeds 80 columns #252: FILE: obexd/plugins/phonebook-ebook.c:245: + /* Prepare pull request, return the prepared request which is passed to phonebook_pull_read */ WARNING:SPACING: space prohibited between function name and open parenthesis '(' #275: FILE: obexd/plugins/phonebook-ebook.c:268: +static void phonebook_pull_read_ready (GObject *source_object, WARNING:SPACING: space prohibited between function name and open parenthesis '(' #292: FILE: obexd/plugins/phonebook-ebook.c:284: + e_book_client_get_contacts_finish (E_BOOK_CLIENT (source_object), WARNING:SPACING: space prohibited between function name and open parenthesis '(' #292: FILE: obexd/plugins/phonebook-ebook.c:284: + e_book_client_get_contacts_finish (E_BOOK_CLIENT (source_object), WARNING:LONG_LINE_COMMENT: line length of 83 exceeds 80 columns #321: FILE: obexd/plugins/phonebook-ebook.c:305: + * Convert each contact to a vCard and append the card to the buffer string. WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #321: FILE: obexd/plugins/phonebook-ebook.c:305: + /* + * Convert each contact to a vCard and append the card to the buffer string. WARNING:LONG_LINE: line length of 92 exceeds 80 columns #324: FILE: obexd/plugins/phonebook-ebook.c:308: + for (count = 0; l && count + data->count < maxcount; l = g_slist_next(l), count++) { WARNING:SPACING: space prohibited between function name and open parenthesis '(' #351: FILE: obexd/plugins/phonebook-ebook.c:330: + g_slist_free_full (contacts, (GDestroyNotify) g_object_unref); WARNING:LONG_LINE_COMMENT: line length of 91 exceeds 80 columns #376: FILE: obexd/plugins/phonebook-ebook.c:351: + /* Retrieve results from the backend, based on the request. Return 0 on success. */ WARNING:LONG_LINE: line length of 83 exceeds 80 columns #389: FILE: obexd/plugins/phonebook-ebook.c:364: + (GAsyncReadyCallback) phonebook_pull_read_ready, WARNING:SPACING: space prohibited between function name and open parenthesis '(' #409: FILE: obexd/plugins/phonebook-ebook.c:384: + e_book_client_get_contact_finish(E_BOOK_CLIENT (source_object), WARNING:LONG_LINE_COMMENT: line length of 81 exceeds 80 columns #464: FILE: obexd/plugins/phonebook-ebook.c:431: + /* Get a contact from the backend, contact must be in cache to succeed */ WARNING:LONG_LINE: line length of 82 exceeds 80 columns #478: FILE: obexd/plugins/phonebook-ebook.c:445: + (GAsyncReadyCallback) phonebook_get_entry_ready, WARNING:SPACING: space prohibited between function name and open parenthesis '(' #510: FILE: obexd/plugins/phonebook-ebook.c:499: + e_book_client_get_contacts_finish (E_BOOK_CLIENT (source_object), WARNING:SPACING: space prohibited between function name and open parenthesis '(' #510: FILE: obexd/plugins/phonebook-ebook.c:499: + e_book_client_get_contacts_finish (E_BOOK_CLIENT (source_object), WARNING:LONG_LINE: line length of 90 exceeds 80 columns #802: FILE: obexd/plugins/phonebook-ebook.c:555: + phonebook_cache_ready_cb ready_cb, void *user_data, int *err) WARNING:LONG_LINE: line length of 86 exceeds 80 columns #875: FILE: obexd/plugins/phonebook-ebook.c:621: + (GAsyncReadyCallback) phonebook_create_cache_ready, ERROR:SPACING: spaces required around that '?' (ctx:VxW) #911: FILE: obexd/plugins/phonebook-ebook.c:657: + gerr != NULL? gerr->message: "NULL"); ^ ERROR:SPACING: spaces required around that ':' (ctx:VxW) #911: FILE: obexd/plugins/phonebook-ebook.c:657: + gerr != NULL? gerr->message: "NULL"); ^ - total: 2 errors, 18 warnings, 889 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] obexd: phonebook-ebook: modernize" has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. configure.ac: specify phonebook plugin at build time WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: Cherry-picked from https://github.com/sailfishos/bluez5/commit/d39ed9e2db8d4f9ab239a859c777e5504459b9dd WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by: #12: Co-authored-by: Dylan Van Assche <me@xxxxxxxxxxxxxxxxx> - total: 0 errors, 2 warnings, 20 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] configure.ac: specify phonebook plugin at build time" has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. obexd: phonebook: Workaround for PTS client not sending mandatory apparams WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #12: Cherry-picked from https://github.com/sailfishos/bluez5/commit/e8001df26e1964ddb98d02ad27ab8f909ffe2f17 WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by: #14: Co-authored-by: Dylan Van Assche <me@xxxxxxxxxxxxxxxxx> - total: 0 errors, 2 warnings, 21 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] obexd: phonebook: Workaround for PTS client not sending" has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ############################## Test: GitLint - FAIL Desc: Run gitlint with rule in .gitlint Output: configure.ac: specify phonebook plugin at build time 7: B1 Line exceeds max length (103>80): "Cherry-picked from https://github.com/sailfishos/bluez5/commit/d39ed9e2db8d4f9ab239a859c777e5504459b9dd"; obexd: phonebook: Workaround for PTS client not sending mandatory apparams 1: T1 Title exceeds max length (74>72): "obexd: phonebook: Workaround for PTS client not sending mandatory apparams" 8: B1 Line exceeds max length (103>80): "Cherry-picked from https://github.com/sailfishos/bluez5/commit/e8001df26e1964ddb98d02ad27ab8f909ffe2f17"; ############################## Test: Prep - Setup ELL - PASS Desc: Clone, build, and install ELL ############################## Test: Build - Prep - PASS Desc: Prepare environment for build ############################## Test: Build - Configure - PASS Desc: Configure the BlueZ source tree ############################## Test: Build - Make - PASS Desc: Build the BlueZ source tree ############################## Test: Make Check - PASS Desc: Run 'make check' ############################## Test: Make Distcheck - PASS Desc: Run distcheck to check the distribution ############################## Test: Build w/ext ELL - Configure - PASS Desc: Configure BlueZ source with '--enable-external-ell' configuration ############################## Test: Build w/ext ELL - Make - PASS Desc: Build BlueZ source with '--enable-external-ell' configuration --- Regards, Linux Bluetooth
