From: Yun-Hao Chung <howardchung@xxxxxxxxxxxx> This registers a device state callback function. It will be used to implement "AffectedByPolicy" property which indicates if there is any service in a device that is being blocked by admin policy. Reviewed-by: Miao-chen Chou <mcchou@xxxxxxxxxxxx> --- The following test steps were performed: 1. start discovery using UI 2. verify device_data were added by checking system log 3. stop discovery 4. verify device_data were removed after a few seconds by checking system log plugins/admin_policy.c | 87 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 87 insertions(+) diff --git a/plugins/admin_policy.c b/plugins/admin_policy.c index c5ad31f761d9..852e79aaa07a 100644 --- a/plugins/admin_policy.c +++ b/plugins/admin_policy.c @@ -20,6 +20,7 @@ #include "src/adapter.h" #include "src/dbus-common.h" +#include "src/device.h" #include "src/error.h" #include "src/log.h" #include "src/plugin.h" @@ -30,6 +31,8 @@ #define ADMIN_POLICY_STATUS_INTERFACE "org.bluez.AdminPolicyStatus1" static DBusConnection *dbus_conn; +static struct queue *devices; /* List of struct device_data objects */ +static unsigned int device_cb_id; /* |policy_data| has the same life cycle as btd_adapter */ static struct btd_admin_policy { @@ -38,6 +41,11 @@ static struct btd_admin_policy { struct queue *service_allowlist; } *policy_data = NULL; +struct device_data { + struct btd_device *device; + char *path; +}; + static struct btd_admin_policy *admin_policy_new(struct btd_adapter *adapter) { struct btd_admin_policy *admin_policy = NULL; @@ -245,6 +253,79 @@ static int admin_policy_adapter_probe(struct btd_adapter *adapter) return 0; } +static bool device_data_match(const void *a, const void *b) +{ + const struct device_data *data = a; + const struct btd_device *dev = b; + + if (!data) { + error("Unexpected NULL device_data"); + return false; + } + + return data->device == dev; +} + +static void free_device_data(struct device_data *data) +{ + g_free(data->path); + g_free(data); +} + +static void remove_device_data(void *data) +{ + struct device_data *device_data = data; + + DBG("device_data for %s removing", device_data->path); + + queue_remove(devices, device_data); + free_device_data(device_data); +} + +static void add_device_data(struct btd_device *device) +{ + struct btd_adapter *adapter = device_get_adapter(device); + struct device_data *data; + + if (queue_find(devices, device_data_match, device)) + return; + + data = g_new0(struct device_data, 1); + if (!data) { + btd_error(btd_adapter_get_index(adapter), + "Failed to allocate memory for device_data"); + return; + } + + data->device = device; + data->path = g_strdup(device_get_path(device)); + queue_push_tail(devices, data); + + DBG("device_data for %s added", data->path); +} + +static void admin_policy_device_state_cb(struct btd_device *device, + enum btd_device_state_t new_state, + void *user_data) +{ + struct device_data *data = NULL; + + switch (new_state) { + case BTD_DEVICE_STATE_INITIALIZING: + warn("Unexpected new state %d", new_state); + return; + case BTD_DEVICE_STATE_AVAILABLE: + add_device_data(device); + break; + case BTD_DEVICE_STATE_REMOVING: + data = queue_find(devices, device_data_match, device); + + if (data) + remove_device_data(data); + break; + } +} + static struct btd_adapter_driver admin_policy_driver = { .name = "admin_policy", .probe = admin_policy_adapter_probe, @@ -256,6 +337,10 @@ static int admin_policy_init(void) DBG(""); dbus_conn = btd_get_dbus_connection(); + devices = queue_new(); + + device_cb_id = btd_device_add_state_cb(admin_policy_device_state_cb, + NULL); return btd_register_adapter_driver(&admin_policy_driver); } @@ -265,6 +350,8 @@ static void admin_policy_exit(void) DBG(""); btd_unregister_adapter_driver(&admin_policy_driver); + queue_destroy(devices, free_device_data); + btd_device_remove_state_cb(device_cb_id); if (policy_data) admin_policy_free(policy_data); -- 2.32.0.93.g670b81a890-goog