Re: [PATCH v9 01/10] Bluetooth: enumerate local supported codec and cache details

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kiran,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on bluetooth/master v5.13-rc5 next-20210608]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kiran-K/Bluetooth-enumerate-local-supported-codec-and-cache-details/20210608-202239
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: mips-randconfig-s032-20210608 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/38ec55e0fc2fabf67d0b5f151700afae12db44f7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kiran-K/Bluetooth-enumerate-local-supported-codec-and-cache-details/20210608-202239
        git checkout 38ec55e0fc2fabf67d0b5f151700afae12db44f7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)
   command-line: note: in included file:
   builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQUIRE redefined
   builtin:0:0: sparse: this was the original definition
   builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_SEQ_CST redefined
   builtin:0:0: sparse: this was the original definition
   builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQ_REL redefined
   builtin:0:0: sparse: this was the original definition
   builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_RELEASE redefined
   builtin:0:0: sparse: this was the original definition
   net/bluetooth/hci_core.c: note: in included file:
   include/net/bluetooth/hci_core.h:142:35: sparse: sparse: array of flexible structures
>> net/bluetooth/hci_core.c:920:28: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] cid @@     got unsigned short [usertype] @@
   net/bluetooth/hci_core.c:920:28: sparse:     expected restricted __le16 [usertype] cid
   net/bluetooth/hci_core.c:920:28: sparse:     got unsigned short [usertype]
>> net/bluetooth/hci_core.c:921:28: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] vid @@     got unsigned short [usertype] @@
   net/bluetooth/hci_core.c:921:28: sparse:     expected restricted __le16 [usertype] vid
   net/bluetooth/hci_core.c:921:28: sparse:     got unsigned short [usertype]

vim +920 net/bluetooth/hci_core.c

   905	
   906	static int hci_codec_list_add(struct list_head *list,
   907				      struct hci_op_read_local_codec_caps *sent,
   908				      struct hci_rp_read_local_codec_caps *rp,
   909				      void *caps,
   910				      __u32 len)
   911	{
   912		struct codec_list *entry;
   913	
   914		entry = kzalloc(sizeof(*entry) + len, GFP_KERNEL);
   915		if (!entry)
   916			return -ENOMEM;
   917	
   918		entry->id = sent->id;
   919		if (sent->id == 0xFF) {
 > 920			entry->cid = __le16_to_cpu(sent->cid);
 > 921			entry->vid = __le16_to_cpu(sent->vid);
   922		}
   923		entry->transport = sent->transport;
   924		entry->len = len;
   925		entry->num_caps = rp->num_caps;
   926		if (rp->num_caps)
   927			memcpy(entry->caps, caps, len);
   928		list_add(&entry->list, list);
   929	
   930		return 0;
   931	}
   932	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux