On Fri, 2021-06-04 at 16:56 +0800, Archie Pusaka wrote: > Hi Bastien, > > Thanks! That was a great input. > I'm not sure though, do we have a standard, proper way to deprecate > macros? > Or does a simple /* deprecated */ comment works for now? I think we might need to add #ifdef around those instead unfortunately, something like "#ifndef BLUETOOTH_NO_DEPRECATED_CONSTANTS" around the old names. > > Cheers, > Archie > > > On Fri, 4 Jun 2021 at 16:39, Bastien Nocera <hadess@xxxxxxxxxx> > wrote: > > > > On Fri, 2021-06-04 at 16:26 +0800, Archie Pusaka wrote: > > > > > > The #define preprocessor terms are unchanged for now to not > > > disturb > > > dependent APIs. > > > > Could we add new defines, and deprecate the old ones? Something > > akin > > to that would help migrate the constants, over time: > > https://gitlab.gnome.org/GNOME/glib/blob/master/glib/gmacros.h#L686-716 > >
