RE: [v1,1/5] Bluetooth: Add helper for serialized HCI command execution

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=492079

---Test result---

Test Summary:
CheckPatch                    FAIL      6.94 seconds
GitLint                       PASS      0.51 seconds
BuildKernel                   PASS      506.87 seconds
TestRunner: Setup             PASS      330.53 seconds
TestRunner: l2cap-tester      PASS      2.51 seconds
TestRunner: bnep-tester       PASS      1.86 seconds
TestRunner: mgmt-tester       FAIL      31.96 seconds
TestRunner: rfcomm-tester     PASS      2.02 seconds
TestRunner: sco-tester        PASS      1.97 seconds
TestRunner: smp-tester        PASS      2.05 seconds
TestRunner: userchan-tester   PASS      1.89 seconds

Details
##############################
Test: CheckPatch - FAIL - 6.94 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
Bluetooth: eir: Move EIR/Adv Data functions to its own file
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#82: 
new file mode 100644

CHECK: braces {} should be used on all arms of this statement
#261: FILE: net/bluetooth/eir.c:175:
+		if (name_len > 48) {
[...]
+		} else
[...]

CHECK: Unbalanced braces around else statement
#264: FILE: net/bluetooth/eir.c:178:
+		} else

CHECK: No space is necessary after a cast
#278: FILE: net/bluetooth/eir.c:192:
+		ptr[2] = (u8) hdev->inq_tx_power;

total: 0 errors, 1 warnings, 3 checks, 1068 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] Bluetooth: eir: Move EIR/Adv Data functions to its own file" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Bluetooth: hci_sync: Make use of hci_cmd_sync_queue set 1
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
Set Device Class - Success 1                         Passed       0.024 seconds

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#215: 
new file mode 100644

CHECK: Alignment should match open parenthesis
#254: FILE: net/bluetooth/hci_sync.c:35:
+	err = wait_event_interruptible_timeout(hdev->req_wait_q,
+			hdev->req_status != HCI_REQ_PEND, timeout);

CHECK: multiple assignments should be avoided
#273: FILE: net/bluetooth/hci_sync.c:54:
+	hdev->req_status = hdev->req_result = 0;

CHECK: Prefer kernel type 'u8' over 'uint8_t'
#302: FILE: net/bluetooth/hci_sync.c:83:
+	uint8_t status;

total: 0 errors, 2 warnings, 3 checks, 652 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] Bluetooth: hci_sync: Make use of hci_cmd_sync_queue set 1" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Bluetooth: hci_sync: Make use of hci_cmd_sync_queue set 2
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
Add Advertising - Failure: LE off                    Passed       0.175 seconds

CHECK: Alignment should match open parenthesis
#138: FILE: net/bluetooth/hci_sync.c:82:
+u8 __hci_cmd_sync_status(struct hci_dev *hdev, u16 opcode, u32 plen,
 			  const void *param, u32 timeout)

CHECK: Alignment should match open parenthesis
#440: FILE: net/bluetooth/hci_sync.c:454:
+	err = __hci_cmd_sync_status(hdev, HCI_OP_LE_SET_EXT_ADV_PARAMS,
+				       sizeof(cp), &cp, HCI_CMD_TIMEOUT);

CHECK: No space is necessary after a cast
#534: FILE: net/bluetooth/hci_sync.c:548:
+	cp = (void *) data;

CHECK: No space is necessary after a cast
#535: FILE: net/bluetooth/hci_sync.c:549:
+	set = (void *) cp->data;

CHECK: Alignment should match open parenthesis
#808: FILE: net/bluetooth/hci_sync.c:822:
+		queue_delayed_work(hdev->req_workqueue,
+			   &hdev->adv_instance_expire,

total: 0 errors, 1 warnings, 5 checks, 1404 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] Bluetooth: hci_sync: Make use of hci_cmd_sync_queue set 2" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Bluetooth: hci_sync: Make use of hci_cmd_sync_queue set 3
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
Add Device - Invalid Params 1                        Passed       0.016 seconds

CHECK: Alignment should match open parenthesis
#233: FILE: net/bluetooth/hci_sync.c:1079:
+	err = __hci_cmd_sync_status(hdev, HCI_OP_LE_DEL_FROM_WHITE_LIST,
+				     sizeof(cp), &cp, HCI_CMD_TIMEOUT);

CHECK: Alignment should match open parenthesis
#307: FILE: net/bluetooth/hci_sync.c:1153:
+	err = __hci_cmd_sync_status(hdev, HCI_OP_LE_ADD_TO_WHITE_LIST,
+				     sizeof(cp), &cp, HCI_CMD_TIMEOUT);

CHECK: Alignment should match open parenthesis
#475: FILE: net/bluetooth/hci_sync.c:1321:
+static int hci_le_set_scan_param_sync(struct hci_dev *hdev, u8 type,
+				       u16 interval, u16 window,

total: 0 errors, 1 warnings, 3 checks, 671 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] Bluetooth: hci_sync: Make use of hci_cmd_sync_queue set 3" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - PASS - 0.51 seconds
Run gitlint with rule in .gitlint


##############################
Test: BuildKernel - PASS - 506.87 seconds
Build Kernel with minimal configuration supports Bluetooth


##############################
Test: TestRunner: Setup - PASS - 330.53 seconds
Setup environment for running Test Runner


##############################
Test: TestRunner: l2cap-tester - PASS - 2.51 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: bnep-tester - PASS - 1.86 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: mgmt-tester - FAIL - 31.96 seconds
Run test-runner with mgmt-tester
Total: 446, Passed: 431 (96.6%), Failed: 1, Not Run: 14

Failed Test Cases
Add Ext Advertising - Success 21 (Timeout expires)   Timed out    3.348 seconds

##############################
Test: TestRunner: rfcomm-tester - PASS - 2.02 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: sco-tester - PASS - 1.97 seconds
Run test-runner with sco-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: smp-tester - PASS - 2.05 seconds
Run test-runner with smp-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: userchan-tester - PASS - 1.89 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0



---
Regards,
Linux Bluetooth

Attachment: l2cap-tester.log
Description: Binary data

Attachment: bnep-tester.log
Description: Binary data

Attachment: mgmt-tester.log
Description: Binary data

Attachment: rfcomm-tester.log
Description: Binary data

Attachment: sco-tester.log
Description: Binary data

Attachment: smp-tester.log
Description: Binary data

Attachment: userchan-tester.log
Description: Binary data


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux